search

TheKevJames / puppet-homebrew

homebrew (+brewcask! +taps!) package installer and provider
https://forge.puppet.com/thekevjames/homebrew
Apache License 2.0
18 stars 44 forks source link

Fix brewcask on first run and update brew install repo #39

Closed jordigg closed 8 years ago

jordigg commented 8 years ago

Fix #32 Current Homebrew script fails to install packages when there's nothing already installed. Manual fix was to install one package manually and then re-run Puppet. Cause was the return of the brew cask --versions command which is never empty since includes warnings and error messages that made the parser fail to work on them due it's string structure. Added a easy fix to check whether the warming exist, if it does, the return value is set to empty. Tested on brand new MacOSX install running El Capitan.

Fix #37 Updated homebrew repo to the official one since we were using the old one which is not maintained anymore.

jordigg commented 8 years ago

Tests fail because

Gem::InstallError: json requires Ruby version ~> 2.0.
jordigg commented 8 years ago

@TheKevJames could you please check this PR? Does the gemfile need an update?

TheKevJames commented 8 years ago

Sorry for the delay in looking at this! I've been stuck with awful internet outside of work hours (I'm borrowing a neighbor's wifi to post this :wink:). Hopefully, that will be resolved within the week; as soon as it is, I'll be turning my attention towards this and the other issues and PRs that have popped up.

TheKevJames commented 8 years ago

Looks great! Thanks for the PR.