search

TheKevJames / puppet-homebrew

homebrew (+brewcask! +taps!) package installer and provider
https://forge.puppet.com/thekevjames/homebrew
Apache License 2.0
18 stars 44 forks source link

Finer-grained permissions on /usr/local #44

Closed TheKevJames closed 8 years ago

TheKevJames commented 8 years ago

For brevity, we currently set 0755 on all of /usr/local. This "works" but causes some files to be marked as modified in brew's git status. Those files should be marked with the correct permissions (0644, probably).

Big output of git status in /usr/local attached:

On branch master
Changes not staged for commit:
    modified:   .github/CONTRIBUTING.md
    modified:   .github/ISSUE_TEMPLATE.md
    modified:   .github/PULL_REQUEST_TEMPLATE.md
    modified:   .gitignore
    modified:   .travis.yml
    modified:   .yardopts
    modified:   CODEOFCONDUCT.md
    modified:   LICENSE.txt
    modified:   Library/.editorconfig
    modified:   Library/.rubocop.yml
    modified:   Library/Homebrew/README.md
    modified:   Library/Homebrew/blacklist.rb
    modified:   Library/Homebrew/brew.rb
    modified:   Library/Homebrew/brew.sh
    modified:   Library/Homebrew/build.rb
    modified:   Library/Homebrew/build_environment.rb
    modified:   Library/Homebrew/build_options.rb
    modified:   Library/Homebrew/cask/.gitattributes
    modified:   Library/Homebrew/cask/.gitignore
    modified:   Library/Homebrew/cask/.rspec
    modified:   Library/Homebrew/cask/.rubocop.yml
    modified:   Library/Homebrew/cask/.simplecov
    modified:   Library/Homebrew/cask/CONDUCT.md
    modified:   Library/Homebrew/cask/CONTRIBUTING.md
    modified:   Library/Homebrew/cask/Gemfile
    modified:   Library/Homebrew/cask/Gemfile.lock
    modified:   Library/Homebrew/cask/LICENSE
    modified:   Library/Homebrew/cask/README.md
    modified:   Library/Homebrew/cask/Rakefile
    modified:   Library/Homebrew/cask/USAGE.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/all_stanzas.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/readme.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/app.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/appcast.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/caveats.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/conflicts_with.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/depends_on.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/flight.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/gpg.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/installer.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/license.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/name.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/pkg.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/sha256.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/suite.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/uninstall.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/url.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/version.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/stanzas/zap.md
    modified:   Library/Homebrew/cask/doc/cask_language_reference/token_reference.md
    modified:   Library/Homebrew/cask/doc/development/adding_a_cask.md
    modified:   Library/Homebrew/cask/doc/development/hacking.md
    modified:   Library/Homebrew/cask/doc/development/maintaining.md
    modified:   Library/Homebrew/cask/doc/faq/apps_with_malware.md
    modified:   Library/Homebrew/cask/doc/faq/not_a_discoverability_service.md
    modified:   Library/Homebrew/cask/doc/faq/rejected_casks.md
    modified:   Library/Homebrew/cask/doc/issue_templates/bug_report.md
    modified:   Library/Homebrew/cask/doc/issue_templates/cask_request.md
    modified:   Library/Homebrew/cask/doc/issue_templates/feature_request.md
    modified:   Library/Homebrew/cask/doc/issue_templates/issue_dead_app.md
    modified:   Library/Homebrew/cask/doc/issue_templates/issue_outdated_cask.md
    modified:   Library/Homebrew/cask/doc/issue_templates/issue_outdated_cask_but_cannot_find_link.md
    modified:   Library/Homebrew/cask/doc/issue_templates/issue_source_not_there_and_cannot_find_it.md
    modified:   Library/Homebrew/cask/doc/readme.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/a_cask_fails_to_install.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/brew_cask_list_shows_wrong_information.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/curl_error_fix_curlrc.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/curl_error_fix_no_download.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/curl_error_fix_outdated.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/curl_error_fix_vendor.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/curl_error_fix_wont_fix.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/permission_denied_error_fix_appdir.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/permission_denied_error_fix_bundle.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/pre_bug_report.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/sha256_mismatch_error_fix_icomplete.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/sha256_mismatch_error_fix_outdated.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/source_is_not_there_fix.md
    modified:   Library/Homebrew/cask/doc/reporting_bugs/uninstall_wrongly_reports_cask_as_not_installed.md
    modified:   Library/Homebrew/cask/lib/hbc.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/abstract_flight_block.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/app.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/artifact.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/audio_unit_plugin.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/base.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/binary.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/colorpicker.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/font.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/input_method.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/installer.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/internet_plugin.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/moved.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/nested_container.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/pkg.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/postflight_block.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/preflight_block.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/prefpane.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/qlplugin.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/relocated.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/screen_saver.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/service.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/stage_only.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/suite.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/symlinked.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/uninstall.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/uninstall_base.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/vst3_plugin.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/vst_plugin.rb
    modified:   Library/Homebrew/cask/lib/hbc/artifact/zap.rb
    modified:   Library/Homebrew/cask/lib/hbc/audit.rb
    modified:   Library/Homebrew/cask/lib/hbc/auditor.rb
    modified:   Library/Homebrew/cask/lib/hbc/cache.rb
    modified:   Library/Homebrew/cask/lib/hbc/cask.rb
    modified:   Library/Homebrew/cask/lib/hbc/cask_dependencies.rb
    modified:   Library/Homebrew/cask/lib/hbc/caskroom.rb
    modified:   Library/Homebrew/cask/lib/hbc/caveats.rb
    modified:   Library/Homebrew/cask/lib/hbc/checkable.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/audit.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/base.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/cat.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/cleanup.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/create.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/doctor.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/edit.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/fetch.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/home.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/info.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/install.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/internal_audit_modified_casks.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/internal_checkurl.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/internal_dump.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/internal_help.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/internal_stanza.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/internal_use_base.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/list.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/search.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/style.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/uninstall.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/update.rb
    modified:   Library/Homebrew/cask/lib/hbc/cli/zap.rb
    modified:   Library/Homebrew/cask/lib/hbc/container.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/air.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/base.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/bzip2.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/cab.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/criteria.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/dmg.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/generic_unar.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/gzip.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/lzma.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/naked.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/otf.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/pkg.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/rar.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/seven_zip.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/sit.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/tar.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/ttf.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/xar.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/xip.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/xz.rb
    modified:   Library/Homebrew/cask/lib/hbc/container/zip.rb
    modified:   Library/Homebrew/cask/lib/hbc/download.rb
    modified:   Library/Homebrew/cask/lib/hbc/download_strategy.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/appcast.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/base.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/caveats.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/conflicts_with.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/container.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/depends_on.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/gpg.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/installer.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/license.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/postflight.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/preflight.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/stanza_proxy.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/uninstall_postflight.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/uninstall_preflight.rb
    modified:   Library/Homebrew/cask/lib/hbc/dsl/version.rb
    modified:   Library/Homebrew/cask/lib/hbc/exceptions.rb
    modified:   Library/Homebrew/cask/lib/hbc/extend.rb
    modified:   Library/Homebrew/cask/lib/hbc/extend/hash.rb
    modified:   Library/Homebrew/cask/lib/hbc/extend/io.rb
    modified:   Library/Homebrew/cask/lib/hbc/extend/optparse.rb
    modified:   Library/Homebrew/cask/lib/hbc/extend/string.rb
    modified:   Library/Homebrew/cask/lib/hbc/fetcher.rb
    modified:   Library/Homebrew/cask/lib/hbc/installer.rb
    modified:   Library/Homebrew/cask/lib/hbc/locations.rb
    modified:   Library/Homebrew/cask/lib/hbc/macos.rb
    modified:   Library/Homebrew/cask/lib/hbc/options.rb
    modified:   Library/Homebrew/cask/lib/hbc/pkg.rb
    modified:   Library/Homebrew/cask/lib/hbc/qualified_token.rb
    modified:   Library/Homebrew/cask/lib/hbc/scopes.rb
    modified:   Library/Homebrew/cask/lib/hbc/source.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/gone.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/path_base.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/path_slash_optional.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/path_slash_required.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/tapped.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/tapped_qualified.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/untapped_qualified.rb
    modified:   Library/Homebrew/cask/lib/hbc/source/uri.rb
    modified:   Library/Homebrew/cask/lib/hbc/staged.rb
    modified:   Library/Homebrew/cask/lib/hbc/system_command.rb
    modified:   Library/Homebrew/cask/lib/hbc/topological_hash.rb
    modified:   Library/Homebrew/cask/lib/hbc/underscore_supporting_uri.rb
    modified:   Library/Homebrew/cask/lib/hbc/url.rb
    modified:   Library/Homebrew/cask/lib/hbc/url_checker.rb
    modified:   Library/Homebrew/cask/lib/hbc/utils.rb
    modified:   Library/Homebrew/cask/lib/hbc/utils/file.rb
    modified:   Library/Homebrew/cask/lib/hbc/verify.rb
    modified:   Library/Homebrew/cask/lib/hbc/verify/checksum.rb
    modified:   Library/Homebrew/cask/lib/hbc/verify/gpg.rb
    modified:   Library/Homebrew/cask/lib/hbc/version.rb
    modified:   Library/Homebrew/cask/lib/hbc/without_source.rb
    modified:   Library/Homebrew/cask/spec/cask/artifact/binary_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/audit_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/cask_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/cli/cleanup_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/cli/doctor_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/cli/style_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/cli_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/download_strategy_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/dsl/stanza_proxy_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/dsl/version_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/macos_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/scopes_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/system_command_result_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/system_command_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/underscore_supporting_uri_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/verify/checksum_spec.rb
    modified:   Library/Homebrew/cask/spec/cask/verify_spec.rb
    modified:   Library/Homebrew/cask/spec/spec_helper.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/appcast-checkpoint-sha256-for-empty-string.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/appcast-invalid-checkpoint.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/appcast-missing-checkpoint.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/appcast-valid-checkpoint.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/booby-trap.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/generic-artifact-absolute-target.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/generic-artifact-no-target.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/generic-artifact-relative-target.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/invalid-sha256.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/missing-homepage.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/missing-license.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/missing-name.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/missing-sha256.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/missing-url.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/missing-version.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/osdn-correct-url-format.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/osdn-incorrect-url-format.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/sha256-for-empty-string.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/sourceforge-correct-url-format.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/sourceforge-incorrect-url-format.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/sourceforge-version-latest-correct-url-format.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/version-latest-string.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/version-latest-with-checksum.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/with-binary.rb
    modified:   Library/Homebrew/cask/spec/support/Casks/with-embedded-binary.rb
    modified:   Library/Homebrew/cask/spec/support/audit_matchers.rb
    modified:   Library/Homebrew/cask/spec/support/binaries/AppWithBinary.zip
    modified:   Library/Homebrew/cask/spec/support/binaries/AppWithEmbeddedBinary.zip
    modified:   Library/Homebrew/cask/spec/support/env_helper.rb
    modified:   Library/Homebrew/cask/spec/support/expectations_hash_helper.rb
    modified:   Library/Homebrew/cask/spec/support/file_helper.rb
    modified:   Library/Homebrew/cask/spec/support/install_helper.rb
    modified:   Library/Homebrew/cask/spec/support/kernel_at_exit_hacks.rb
    modified:   Library/Homebrew/cask/spec/support/sha256_helper.rb
    modified:   Library/Homebrew/cask/test/Casks/compliance_test.rb
    modified:   Library/Homebrew/cask/test/README.md
    modified:   Library/Homebrew/cask/test/cask/accessibility_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/alt_target_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/app_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/generic_artifact_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/nested_container_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/pkg_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/postflight_block_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/preflight_block_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/suite_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/two_apps_correct_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/two_apps_incorrect_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/uninstall_test.rb
    modified:   Library/Homebrew/cask/test/cask/artifact/zap_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/audit_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/cat_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/create_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/edit_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/fetch_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/home_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/info_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/install_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/list_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/options_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/search_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/uninstall_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/version_test.rb
    modified:   Library/Homebrew/cask/test/cask/cli/zap_test.rb
    modified:   Library/Homebrew/cask/test/cask/container/dmg_test.rb
    modified:   Library/Homebrew/cask/test/cask/container/naked_test.rb
    modified:   Library/Homebrew/cask/test/cask/depends_on_test.rb
    modified:   Library/Homebrew/cask/test/cask/dsl/caveats_test.rb
    modified:   Library/Homebrew/cask/test/cask/dsl/postflight_test.rb
    modified:   Library/Homebrew/cask/test/cask/dsl/preflight_test.rb
    modified:   Library/Homebrew/cask/test/cask/dsl/uninstall_postflight_test.rb
    modified:   Library/Homebrew/cask/test/cask/dsl/uninstall_preflight_test.rb
    modified:   Library/Homebrew/cask/test/cask/dsl_test.rb
    modified:   Library/Homebrew/cask/test/cask/installer_test.rb
    modified:   Library/Homebrew/cask/test/cask/pkg_test.rb
    modified:   Library/Homebrew/cask/test/cask/staged_test.rb
    modified:   Library/Homebrew/cask/test/cask/url_checker_test.rb
    modified:   Library/Homebrew/cask/test/cask_test.rb
    modified:   Library/Homebrew/cask/test/plist/parser_test.rb
    modified:   Library/Homebrew/cask/test/support/Casks/appdir-interpolation.rb
    modified:   Library/Homebrew/cask/test/support/Casks/auto-updates.rb
    modified:   Library/Homebrew/cask/test/support/Casks/bad-checksum.rb
    modified:   Library/Homebrew/cask/test/support/Casks/basic-cask.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-7z.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-air.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-bzip2.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-cab.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-dmg.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-gzip.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-lzma.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-pkg.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-rar.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-sit.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-tar-gz.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-xar.rb
    modified:   Library/Homebrew/cask/test/support/Casks/container-xz.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-appcast-multiple.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-appcast-url.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-conflicts-with-key.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-depends-on-arch-value.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-depends-on-key.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-depends-on-macos-bad-release.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-depends-on-macos-conflicting-forms.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-depends-on-x11-value.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-conflicting-keys.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-key-id.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-key-url.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-missing-key.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-multiple-stanzas.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-parameter.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-signature-url.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-gpg-type.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-header-format.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-header-token-mismatch.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-header-version.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-license-multiple.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-license-value.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-stage-only-conflict.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-two-homepage.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-two-url.rb
    modified:   Library/Homebrew/cask/test/support/Casks/invalid/invalid-two-version.rb
    modified:   Library/Homebrew/cask/test/support/Casks/local-caffeine.rb
    modified:   Library/Homebrew/cask/test/support/Casks/local-transmission.rb
    modified:   Library/Homebrew/cask/test/support/Casks/missing-checksum.rb
    modified:   Library/Homebrew/cask/test/support/Casks/naked-executable.rb
    modified:   Library/Homebrew/cask/test/support/Casks/nested-app.rb
    modified:   Library/Homebrew/cask/test/support/Casks/no-checksum.rb
    modified:   Library/Homebrew/cask/test/support/Casks/no-dsl-version.rb
    modified:   Library/Homebrew/cask/test/support/Casks/stage-only.rb
    modified:   Library/Homebrew/cask/test/support/Casks/test-opera-mail.rb
    modified:   Library/Homebrew/cask/test/support/Casks/test-opera.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-accessibility-access.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-alt-target.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-appcast.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-caveats.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-conditional-caveats.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-conflicts-with.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-arch-failure.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-arch.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-cask-cyclic-helper.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-cask-cyclic.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-cask-multiple.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-cask.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-formula-multiple.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-formula.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-macos-array.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-macos-comparison.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-macos-failure.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-macos-string.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-macos-symbol.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-x11-false.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-depends-on-x11.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-generic-artifact-no-target.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-generic-artifact.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-gpg-key-url.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-gpg.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-installable.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-installer-manual.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-installer-script.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-license.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-macosx-dir.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-pkgutil-zap.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-suite.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-two-apps-correct.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-two-apps-incorrect.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-two-apps-subdir.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-delete.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-early-script.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-kext.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-launchctl.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-login-item.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-pkgutil.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-quit.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-rmdir.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-script.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-signal.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-uninstall-trash.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-delete.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-early-script.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-kext.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-launchctl.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-login-item.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-pkgutil.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-quit.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-rmdir.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-script.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-signal.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap-trash.rb
    modified:   Library/Homebrew/cask/test/support/Casks/with-zap.rb
    modified:   Library/Homebrew/cask/test/support/binaries/MyFancyApp.zip
    modified:   Library/Homebrew/cask/test/support/binaries/MyFancyPkg.zip
    modified:   Library/Homebrew/cask/test/support/binaries/NestedApp.dmg.zip
    modified:   Library/Homebrew/cask/test/support/binaries/caffeine-suite.zip
    modified:   Library/Homebrew/cask/test/support/binaries/caffeine.zip
    modified:   Library/Homebrew/cask/test/support/binaries/caffeines-subdir.zip
    modified:   Library/Homebrew/cask/test/support/binaries/caffeines.zip
    modified:   Library/Homebrew/cask/test/support/binaries/container.7z
    modified:   Library/Homebrew/cask/test/support/binaries/container.air
    modified:   Library/Homebrew/cask/test/support/binaries/container.cab
    modified:   Library/Homebrew/cask/test/support/binaries/container.dmg
    modified:   Library/Homebrew/cask/test/support/binaries/container.pkg
    modified:   Library/Homebrew/cask/test/support/binaries/container.rar
    modified:   Library/Homebrew/cask/test/support/binaries/container.tar.gz
    modified:   Library/Homebrew/cask/test/support/binaries/container.xar
    modified:   Library/Homebrew/cask/test/support/binaries/empty_directory/.gitignore
    modified:   Library/Homebrew/cask/test/support/binaries/transmission-2.61.dmg
    modified:   Library/Homebrew/cask/test/support/cleanup.rb
    modified:   Library/Homebrew/cask/test/support/fake_dirs.rb
    modified:   Library/Homebrew/cask/test/support/fake_fetcher.rb
    modified:   Library/Homebrew/cask/test/support/fake_system_command.rb
    modified:   Library/Homebrew/cask/test/support/never_sudo_system_command.rb
    modified:   Library/Homebrew/cask/test/support/shared_examples.rb
    modified:   Library/Homebrew/cask/test/support/shared_examples/dsl_base.rb
    modified:   Library/Homebrew/cask/test/support/shared_examples/staged.rb
    modified:   Library/Homebrew/cask/test/syntax_test.rb
    modified:   Library/Homebrew/cask/test/test_helper.rb
    modified:   Library/Homebrew/caveats.rb
    modified:   Library/Homebrew/checksum.rb
    modified:   Library/Homebrew/cleaner.rb
    modified:   Library/Homebrew/cleanup.rb
    modified:   Library/Homebrew/cmd/--cache.rb
    modified:   Library/Homebrew/cmd/--cellar.rb
    modified:   Library/Homebrew/cmd/--env.rb
    modified:   Library/Homebrew/cmd/--prefix.rb
    modified:   Library/Homebrew/cmd/--repository.rb
    modified:   Library/Homebrew/cmd/--version.rb
    modified:   Library/Homebrew/cmd/analytics.rb
    modified:   Library/Homebrew/cmd/audit.rb
    modified:   Library/Homebrew/cmd/bottle.rb
    modified:   Library/Homebrew/cmd/cat.rb
    modified:   Library/Homebrew/cmd/cleanup.rb
    modified:   Library/Homebrew/cmd/command.rb
    modified:   Library/Homebrew/cmd/commands.rb
    modified:   Library/Homebrew/cmd/config.rb
    modified:   Library/Homebrew/cmd/create.rb
    modified:   Library/Homebrew/cmd/deps.rb
    modified:   Library/Homebrew/cmd/desc.rb
    modified:   Library/Homebrew/cmd/diy.rb
    modified:   Library/Homebrew/cmd/doctor.rb
    modified:   Library/Homebrew/cmd/edit.rb
    modified:   Library/Homebrew/cmd/fetch.rb
    modified:   Library/Homebrew/cmd/gist-logs.rb
    modified:   Library/Homebrew/cmd/help.rb
    modified:   Library/Homebrew/cmd/home.rb
    modified:   Library/Homebrew/cmd/info.rb
    modified:   Library/Homebrew/cmd/install.rb
    modified:   Library/Homebrew/cmd/irb.rb
    modified:   Library/Homebrew/cmd/leaves.rb
    modified:   Library/Homebrew/cmd/link.rb
    modified:   Library/Homebrew/cmd/linkapps.rb
    modified:   Library/Homebrew/cmd/list.rb
    modified:   Library/Homebrew/cmd/log.rb
    modified:   Library/Homebrew/cmd/man.rb
    modified:   Library/Homebrew/cmd/migrate.rb
    modified:   Library/Homebrew/cmd/missing.rb
    modified:   Library/Homebrew/cmd/options.rb
    modified:   Library/Homebrew/cmd/outdated.rb
    modified:   Library/Homebrew/cmd/pin.rb
    modified:   Library/Homebrew/cmd/postinstall.rb
    modified:   Library/Homebrew/cmd/prune.rb
    modified:   Library/Homebrew/cmd/pull.rb
    modified:   Library/Homebrew/cmd/readall.rb
    modified:   Library/Homebrew/cmd/reinstall.rb
    modified:   Library/Homebrew/cmd/search.rb
    modified:   Library/Homebrew/cmd/sh.rb
    modified:   Library/Homebrew/cmd/style.rb
    modified:   Library/Homebrew/cmd/switch.rb
    modified:   Library/Homebrew/cmd/tap-info.rb
    modified:   Library/Homebrew/cmd/tap-pin.rb
    modified:   Library/Homebrew/cmd/tap-readme.rb
    modified:   Library/Homebrew/cmd/tap-unpin.rb
    modified:   Library/Homebrew/cmd/tap.rb
    modified:   Library/Homebrew/cmd/test.rb
    modified:   Library/Homebrew/cmd/tests.rb
    modified:   Library/Homebrew/cmd/uninstall.rb
    modified:   Library/Homebrew/cmd/unlink.rb
    modified:   Library/Homebrew/cmd/unlinkapps.rb
    modified:   Library/Homebrew/cmd/unpack.rb
    modified:   Library/Homebrew/cmd/unpin.rb
    modified:   Library/Homebrew/cmd/untap.rb
    modified:   Library/Homebrew/cmd/update-report.rb
    modified:   Library/Homebrew/cmd/update.sh
    modified:   Library/Homebrew/cmd/upgrade.rb
    modified:   Library/Homebrew/cmd/uses.rb
    modified:   Library/Homebrew/cmd/vendor-install.sh
    modified:   Library/Homebrew/compat.rb
    modified:   Library/Homebrew/compat/.rubocop.yml
    modified:   Library/Homebrew/compat/dependency_collector.rb
    modified:   Library/Homebrew/compat/download_strategy.rb
    modified:   Library/Homebrew/compat/fails_with_llvm.rb
    modified:   Library/Homebrew/compat/formula.rb
    modified:   Library/Homebrew/compat/formula_specialties.rb
    modified:   Library/Homebrew/compat/hardware.rb
    modified:   Library/Homebrew/compat/keg.rb
    modified:   Library/Homebrew/compat/language/haskell.rb
    modified:   Library/Homebrew/compat/macos.rb
    modified:   Library/Homebrew/compat/md5.rb
    modified:   Library/Homebrew/compat/pathname.rb
    modified:   Library/Homebrew/compat/requirements.rb
    modified:   Library/Homebrew/compat/sha1.rb
    modified:   Library/Homebrew/compat/software_spec.rb
    modified:   Library/Homebrew/compat/tap.rb
    modified:   Library/Homebrew/compat/version.rb
    modified:   Library/Homebrew/compat/xcode.rb
    modified:   Library/Homebrew/compilers.rb
    modified:   Library/Homebrew/config.rb
    modified:   Library/Homebrew/cxxstdlib.rb
    modified:   Library/Homebrew/debrew.rb
    modified:   Library/Homebrew/debrew/irb.rb
    modified:   Library/Homebrew/dependable.rb
    modified:   Library/Homebrew/dependencies.rb
    modified:   Library/Homebrew/dependency.rb
    modified:   Library/Homebrew/dependency_collector.rb
    modified:   Library/Homebrew/descriptions.rb
    modified:   Library/Homebrew/dev-cmd/aspell-dictionaries.rb
    modified:   Library/Homebrew/dev-cmd/boneyard-formula-pr.rb
    modified:   Library/Homebrew/dev-cmd/bump-formula-pr.rb
    modified:   Library/Homebrew/dev-cmd/linkage.rb
    modified:   Library/Homebrew/dev-cmd/mirror.rb
    modified:   Library/Homebrew/dev-cmd/test-bot.rb
    modified:   Library/Homebrew/dev-cmd/update-test.rb
    modified:   Library/Homebrew/development_tools.rb
    modified:   Library/Homebrew/diagnostic.rb
    modified:   Library/Homebrew/download_strategy.rb
    modified:   Library/Homebrew/emoji.rb
    modified:   Library/Homebrew/exceptions.rb
    modified:   Library/Homebrew/extend/ARGV.rb
    modified:   Library/Homebrew/extend/ENV.rb
    modified:   Library/Homebrew/extend/ENV/shared.rb
    modified:   Library/Homebrew/extend/ENV/std.rb
    modified:   Library/Homebrew/extend/ENV/super.rb
    modified:   Library/Homebrew/extend/enumerable.rb
    modified:   Library/Homebrew/extend/fileutils.rb
    modified:   Library/Homebrew/extend/git_repository.rb
    modified:   Library/Homebrew/extend/module.rb
    modified:   Library/Homebrew/extend/os/blacklist.rb
    modified:   Library/Homebrew/extend/os/bottles.rb
    modified:   Library/Homebrew/extend/os/cleaner.rb
    modified:   Library/Homebrew/extend/os/development_tools.rb
    modified:   Library/Homebrew/extend/os/diagnostic.rb
    modified:   Library/Homebrew/extend/os/emoji.rb
    modified:   Library/Homebrew/extend/os/extend/ENV/shared.rb
    modified:   Library/Homebrew/extend/os/extend/ENV/std.rb
    modified:   Library/Homebrew/extend/os/extend/ENV/super.rb
    modified:   Library/Homebrew/extend/os/formula_cellar_checks.rb
    modified:   Library/Homebrew/extend/os/hardware.rb
    modified:   Library/Homebrew/extend/os/keg_relocate.rb
    modified:   Library/Homebrew/extend/os/linux/hardware/cpu.rb
    modified:   Library/Homebrew/extend/os/mac/blacklist.rb
    modified:   Library/Homebrew/extend/os/mac/cleaner.rb
    modified:   Library/Homebrew/extend/os/mac/development_tools.rb
    modified:   Library/Homebrew/extend/os/mac/diagnostic.rb
    modified:   Library/Homebrew/extend/os/mac/emoji.rb
    modified:   Library/Homebrew/extend/os/mac/extend/ENV/shared.rb
    modified:   Library/Homebrew/extend/os/mac/extend/ENV/std.rb
    modified:   Library/Homebrew/extend/os/mac/extend/ENV/super.rb
    modified:   Library/Homebrew/extend/os/mac/formula_cellar_checks.rb
    modified:   Library/Homebrew/extend/os/mac/hardware/cpu.rb
    modified:   Library/Homebrew/extend/os/mac/keg_relocate.rb
    modified:   Library/Homebrew/extend/os/mac/system_config.rb
    modified:   Library/Homebrew/extend/os/mac/utils/bottles.rb
    modified:   Library/Homebrew/extend/os/system_config.rb
    modified:   Library/Homebrew/extend/pathname.rb
    modified:   Library/Homebrew/extend/string.rb
    modified:   Library/Homebrew/formula.rb
    modified:   Library/Homebrew/formula_assertions.rb
    modified:   Library/Homebrew/formula_cellar_checks.rb
    modified:   Library/Homebrew/formula_installer.rb
    modified:   Library/Homebrew/formula_lock.rb
    modified:   Library/Homebrew/formula_pin.rb
    modified:   Library/Homebrew/formula_support.rb
    modified:   Library/Homebrew/formula_versions.rb
    modified:   Library/Homebrew/formulary.rb
    modified:   Library/Homebrew/global.rb
    modified:   Library/Homebrew/gpg.rb
    modified:   Library/Homebrew/hardware.rb
    modified:   Library/Homebrew/hooks/bottles.rb
    modified:   Library/Homebrew/install_renamed.rb
    modified:   Library/Homebrew/keg.rb
    modified:   Library/Homebrew/keg_relocate.rb
    modified:   Library/Homebrew/language/go.rb
    modified:   Library/Homebrew/language/haskell.rb
    modified:   Library/Homebrew/language/java.rb
    modified:   Library/Homebrew/language/node.rb
    modified:   Library/Homebrew/language/python.rb
    modified:   Library/Homebrew/language/python_virtualenv_constants.rb
    modified:   Library/Homebrew/ld64_dependency.rb
    modified:   Library/Homebrew/manpages/brew-cask.1.md
    modified:   Library/Homebrew/manpages/brew.1.md.erb
    modified:   Library/Homebrew/metafiles.rb
    modified:   Library/Homebrew/migrator.rb
    modified:   Library/Homebrew/official_taps.rb
    modified:   Library/Homebrew/options.rb
    modified:   Library/Homebrew/os.rb
    modified:   Library/Homebrew/os/mac.rb
    modified:   Library/Homebrew/os/mac/architecture_list.rb
    modified:   Library/Homebrew/os/mac/cctools_keg.rb
    modified:   Library/Homebrew/os/mac/cctools_mach.rb
    modified:   Library/Homebrew/os/mac/keg.rb
    modified:   Library/Homebrew/os/mac/linkage_checker.rb
    modified:   Library/Homebrew/os/mac/pathname.rb
    modified:   Library/Homebrew/os/mac/pkgconfig/10.10/libcurl.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.10/libexslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.10/libxml-2.0.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.10/libxslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.10/sqlite3.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.10/zlib.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.11/libcurl.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.11/libexslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.11/libxml-2.0.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.11/libxslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.11/sqlite3.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.11/zlib.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.12/libcurl.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.12/libexslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.12/libxml-2.0.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.12/libxslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.12/sqlite3.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.12/zlib.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.5/libcrypto.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.5/libcurl.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.6/sqlite3.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.6/zlib.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.7/sqlite3.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.7/zlib.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.8/libcurl.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.8/libexslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.8/libxml-2.0.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.8/libxslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.8/sqlite3.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.8/zlib.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.9/libcurl.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.9/libexslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.9/libxml-2.0.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.9/libxslt.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.9/sqlite3.pc
    modified:   Library/Homebrew/os/mac/pkgconfig/10.9/zlib.pc
    modified:   Library/Homebrew/os/mac/ruby_keg.rb
    modified:   Library/Homebrew/os/mac/ruby_mach.rb
    modified:   Library/Homebrew/os/mac/sdk.rb
    modified:   Library/Homebrew/os/mac/shared_mach.rb
    modified:   Library/Homebrew/os/mac/version.rb
    modified:   Library/Homebrew/os/mac/xcode.rb
    modified:   Library/Homebrew/os/mac/xquartz.rb
    modified:   Library/Homebrew/patch.rb
    modified:   Library/Homebrew/pkg_version.rb
    modified:   Library/Homebrew/postinstall.rb
    modified:   Library/Homebrew/readall.rb
    modified:   Library/Homebrew/requirement.rb
    modified:   Library/Homebrew/requirements.rb
    modified:   Library/Homebrew/requirements/apr_requirement.rb
    modified:   Library/Homebrew/requirements/cctools_requirement.rb
    modified:   Library/Homebrew/requirements/emacs_requirement.rb
    modified:   Library/Homebrew/requirements/fortran_requirement.rb
    modified:   Library/Homebrew/requirements/gpg2_requirement.rb
    modified:   Library/Homebrew/requirements/java_requirement.rb
    modified:   Library/Homebrew/requirements/language_module_requirement.rb
    modified:   Library/Homebrew/requirements/maximum_macos_requirement.rb
    modified:   Library/Homebrew/requirements/minimum_macos_requirement.rb
    modified:   Library/Homebrew/requirements/mpi_requirement.rb
    modified:   Library/Homebrew/requirements/osxfuse_requirement.rb
    modified:   Library/Homebrew/requirements/perl_requirement.rb
    modified:   Library/Homebrew/requirements/python_requirement.rb
    modified:   Library/Homebrew/requirements/ruby_requirement.rb
    modified:   Library/Homebrew/requirements/tuntap_requirement.rb
    modified:   Library/Homebrew/requirements/unsigned_kext_requirement.rb
    modified:   Library/Homebrew/requirements/x11_requirement.rb
    modified:   Library/Homebrew/resource.rb
    modified:   Library/Homebrew/sandbox.rb
    modified:   Library/Homebrew/software_spec.rb
    modified:   Library/Homebrew/system_config.rb
    modified:   Library/Homebrew/tab.rb
    modified:   Library/Homebrew/tap.rb
    modified:   Library/Homebrew/tap_constants.rb
    modified:   Library/Homebrew/test.rb
    modified:   Library/Homebrew/test/.rubocop.yml
    modified:   Library/Homebrew/test/.simplecov
    modified:   Library/Homebrew/test/Gemfile
    modified:   Library/Homebrew/test/Gemfile.lock
    modified:   Library/Homebrew/test/Rakefile
    modified:   Library/Homebrew/test/bottles/testball_bottle-0.1.yosemite.bottle.tar.gz
    modified:   Library/Homebrew/test/fixtures/receipt.json
    modified:   Library/Homebrew/test/fixtures/receipt_old.json
    modified:   Library/Homebrew/test/fixtures/test.diff
    modified:   Library/Homebrew/test/fixtures/test.eps
    modified:   Library/Homebrew/test/fixtures/test.gif
    modified:   Library/Homebrew/test/fixtures/test.ico
    modified:   Library/Homebrew/test/fixtures/test.jpg
    modified:   Library/Homebrew/test/fixtures/test.mp3
    modified:   Library/Homebrew/test/fixtures/test.pcap
    modified:   Library/Homebrew/test/fixtures/test.pdf
    modified:   Library/Homebrew/test/fixtures/test.png
    modified:   Library/Homebrew/test/fixtures/test.ps
    modified:   Library/Homebrew/test/fixtures/test.svg
    modified:   Library/Homebrew/test/fixtures/test.tiff
    modified:   Library/Homebrew/test/fixtures/test.wav
    modified:   Library/Homebrew/test/fixtures/updater_fixture.yaml
    modified:   Library/Homebrew/test/helper/shutup.rb
    modified:   Library/Homebrew/test/lib/config.rb
    modified:   Library/Homebrew/test/lib/integration_mocks.rb
    modified:   Library/Homebrew/test/mach/fat.bundle
    modified:   Library/Homebrew/test/mach/fat.dylib
    modified:   Library/Homebrew/test/mach/i386.bundle
    modified:   Library/Homebrew/test/mach/i386.dylib
    modified:   Library/Homebrew/test/mach/x86_64.bundle
    modified:   Library/Homebrew/test/mach/x86_64.dylib
    modified:   Library/Homebrew/test/patches/noop-a.diff
    modified:   Library/Homebrew/test/patches/noop-b.diff
    modified:   Library/Homebrew/test/patches/noop-c.diff
    modified:   Library/Homebrew/test/tarballs/testball-0.1-patches.tgz
    modified:   Library/Homebrew/test/tarballs/testball-0.1.tbz
    modified:   Library/Homebrew/test/test_ARGV.rb
    modified:   Library/Homebrew/test/test_ENV.rb
    modified:   Library/Homebrew/test/test_bash.rb
    modified:   Library/Homebrew/test/test_blacklist.rb
    modified:   Library/Homebrew/test/test_bottle_collector.rb
    modified:   Library/Homebrew/test/test_bottle_filename.rb
    modified:   Library/Homebrew/test/test_bottle_hooks.rb
    modified:   Library/Homebrew/test/test_build_environment.rb
    modified:   Library/Homebrew/test/test_build_options.rb
    modified:   Library/Homebrew/test/test_caveats.rb
    modified:   Library/Homebrew/test/test_checksum.rb
    modified:   Library/Homebrew/test/test_checksum_verification.rb
    modified:   Library/Homebrew/test/test_cleaner.rb
    modified:   Library/Homebrew/test/test_cleanup.rb
    modified:   Library/Homebrew/test/test_cmd_audit.rb
    modified:   Library/Homebrew/test/test_cmd_info.rb
    modified:   Library/Homebrew/test/test_cmd_testbot.rb
    modified:   Library/Homebrew/test/test_commands.rb
    modified:   Library/Homebrew/test/test_compiler_failure.rb
    modified:   Library/Homebrew/test/test_compiler_selector.rb
    modified:   Library/Homebrew/test/test_dependencies.rb
    modified:   Library/Homebrew/test/test_dependency.rb
    modified:   Library/Homebrew/test/test_dependency_collector.rb
    modified:   Library/Homebrew/test/test_dependency_expansion.rb
    modified:   Library/Homebrew/test/test_descriptions.rb
    modified:   Library/Homebrew/test/test_diagnostic.rb
    modified:   Library/Homebrew/test/test_download_strategies.rb
    modified:   Library/Homebrew/test/test_exceptions.rb
    modified:   Library/Homebrew/test/test_formula.rb
    modified:   Library/Homebrew/test/test_formula_installer.rb
    modified:   Library/Homebrew/test/test_formula_installer_bottle.rb
    modified:   Library/Homebrew/test/test_formula_lock.rb
    modified:   Library/Homebrew/test/test_formula_pin.rb
    modified:   Library/Homebrew/test/test_formula_spec_selection.rb
    modified:   Library/Homebrew/test/test_formula_support.rb
    modified:   Library/Homebrew/test/test_formula_validation.rb
    modified:   Library/Homebrew/test/test_formulary.rb
    modified:   Library/Homebrew/test/test_gpg.rb
    modified:   Library/Homebrew/test/test_gpg2_requirement.rb
    modified:   Library/Homebrew/test/test_hardware.rb
    modified:   Library/Homebrew/test/test_inreplace.rb
    modified:   Library/Homebrew/test/test_integration_cmds.rb
    modified:   Library/Homebrew/test/test_json.rb
    modified:   Library/Homebrew/test/test_keg.rb
    modified:   Library/Homebrew/test/test_language_go.rb
    modified:   Library/Homebrew/test/test_language_module_requirement.rb
    modified:   Library/Homebrew/test/test_language_python.rb
    modified:   Library/Homebrew/test/test_migrator.rb
    modified:   Library/Homebrew/test/test_mpi_requirement.rb
    modified:   Library/Homebrew/test/test_options.rb
    modified:   Library/Homebrew/test/test_os_mac_blacklist.rb
    modified:   Library/Homebrew/test/test_os_mac_bottle_collector.rb
    modified:   Library/Homebrew/test/test_os_mac_bottle_tag.rb
    modified:   Library/Homebrew/test/test_os_mac_dependency_collector.rb
    modified:   Library/Homebrew/test/test_os_mac_diagnostic.rb
    modified:   Library/Homebrew/test/test_os_mac_keg.rb
    modified:   Library/Homebrew/test/test_os_mac_mach.rb
    modified:   Library/Homebrew/test/test_os_mac_version.rb
    modified:   Library/Homebrew/test/test_os_mac_x11_requirement.rb
    modified:   Library/Homebrew/test/test_patch.rb
    modified:   Library/Homebrew/test/test_patching.rb
    modified:   Library/Homebrew/test/test_pathname.rb
    modified:   Library/Homebrew/test/test_pkg_version.rb
    modified:   Library/Homebrew/test/test_requirement.rb
    modified:   Library/Homebrew/test/test_resource.rb
    modified:   Library/Homebrew/test/test_sandbox.rb
    modified:   Library/Homebrew/test/test_software_spec.rb
    modified:   Library/Homebrew/test/test_stdlib.rb
    modified:   Library/Homebrew/test/test_string.rb
    modified:   Library/Homebrew/test/test_tab.rb
    modified:   Library/Homebrew/test/test_tap.rb
    modified:   Library/Homebrew/test/test_update_report.rb
    modified:   Library/Homebrew/test/test_utils.rb
    modified:   Library/Homebrew/test/test_versions.rb
    modified:   Library/Homebrew/test/test_x11_requirement.rb
    modified:   Library/Homebrew/test/testball.rb
    modified:   Library/Homebrew/test/testball_bottle.rb
    modified:   Library/Homebrew/test/testing_env.rb
    modified:   Library/Homebrew/utils.rb
    modified:   Library/Homebrew/utils/analytics.rb
    modified:   Library/Homebrew/utils/analytics.sh
    modified:   Library/Homebrew/utils/bottles.rb
    modified:   Library/Homebrew/utils/curl.rb
    modified:   Library/Homebrew/utils/fork.rb
    modified:   Library/Homebrew/utils/git.rb
    modified:   Library/Homebrew/utils/github.rb
    modified:   Library/Homebrew/utils/hash.rb
    modified:   Library/Homebrew/utils/inreplace.rb
    modified:   Library/Homebrew/utils/json.rb
    modified:   Library/Homebrew/utils/lock.sh
    modified:   Library/Homebrew/utils/popen.rb
    modified:   Library/Homebrew/utils/ruby.sh
    modified:   Library/Homebrew/vendor/README.md
    modified:   Library/Homebrew/vendor/macho/macho.rb
    modified:   Library/Homebrew/vendor/macho/macho/exceptions.rb
    modified:   Library/Homebrew/vendor/macho/macho/fat_file.rb
    modified:   Library/Homebrew/vendor/macho/macho/headers.rb
    modified:   Library/Homebrew/vendor/macho/macho/load_commands.rb
    modified:   Library/Homebrew/vendor/macho/macho/macho_file.rb
    modified:   Library/Homebrew/vendor/macho/macho/open.rb
    modified:   Library/Homebrew/vendor/macho/macho/sections.rb
    modified:   Library/Homebrew/vendor/macho/macho/structure.rb
    modified:   Library/Homebrew/vendor/macho/macho/tools.rb
    modified:   Library/Homebrew/vendor/macho/macho/utils.rb
    modified:   Library/Homebrew/vendor/macho/macho/view.rb
    modified:   Library/Homebrew/vendor/okjson.rb
    modified:   Library/Homebrew/vendor/plist/plist/generator.rb
    modified:   Library/Homebrew/vendor/plist/plist/parser.rb
    modified:   Library/Homebrew/vendor/portable-ruby-version
    modified:   Library/Homebrew/version.rb
    modified:   README.md
    modified:   etc/bash_completion.d/brew
    modified:   share/doc/homebrew/Acceptable-Formulae.md
    modified:   share/doc/homebrew/Analytics.md
    modified:   share/doc/homebrew/Bottles.md
    modified:   share/doc/homebrew/Brew-Test-Bot-For-Core-Contributors.md
    modified:   share/doc/homebrew/Brew-Test-Bot.md
    modified:   share/doc/homebrew/C++-Standard-Libraries.md
    modified:   share/doc/homebrew/Checksum_Deprecation.md
    modified:   share/doc/homebrew/Common-Issues-for-Core-Contributors.md
    modified:   share/doc/homebrew/Common-Issues.md
    modified:   share/doc/homebrew/Custom-GCC-and-cross-compilers.md
    modified:   share/doc/homebrew/External-Commands.md
    modified:   share/doc/homebrew/FAQ.md
    modified:   share/doc/homebrew/Formula-Cookbook.md
    modified:   share/doc/homebrew/Gems,-Eggs-and-Perl-Modules.md
    modified:   share/doc/homebrew/Homebrew-and-Python.md
    modified:   share/doc/homebrew/How-To-Open-a-Homebrew-Pull-Request-(and-get-it-merged).md
    modified:   share/doc/homebrew/How-to-Create-and-Maintain-a-Tap.md
    modified:   share/doc/homebrew/How-to-build-software-outside-Homebrew-with-Homebrew-keg-only-dependencies.md
    modified:   share/doc/homebrew/Installation.md
    modified:   share/doc/homebrew/Interesting-Taps-&-Branches.md
    modified:   share/doc/homebrew/Kickstarter-Supporters.md
    modified:   share/doc/homebrew/Maintainer-Guidelines.md
    modified:   share/doc/homebrew/Maintainers-Avoiding-Burnout.md
    modified:   share/doc/homebrew/Migrating-A-Formula-To-A-Tap.md
    modified:   share/doc/homebrew/New-Maintainer-Checklist.md
    modified:   share/doc/homebrew/Node-for-Formula-Authors.md
    modified:   share/doc/homebrew/Prose-Style-Guidelines.md
    modified:   share/doc/homebrew/Python-for-Formula-Authors.md
    modified:   share/doc/homebrew/Querying-Brew.md
    modified:   share/doc/homebrew/README.md
    modified:   share/doc/homebrew/Rename-A-Formula.md
    modified:   share/doc/homebrew/Tips-N'-Tricks.md
    modified:   share/doc/homebrew/Troubleshooting.md
    modified:   share/doc/homebrew/Xcode.md
    modified:   share/doc/homebrew/brew-tap.md
    modified:   share/doc/homebrew/brew.1.html
    modified:   share/doc/homebrew/images/analytics.png
    modified:   share/doc/homebrew/images/brew-test-bot-failed-jenkins.png
    modified:   share/doc/homebrew/images/brew-test-bot-failed-pr.png
    modified:   share/doc/homebrew/images/brew-test-bot-failed-test.png
    modified:   share/doc/homebrew/images/brew-test-bot-passed-jenkins.png
    modified:   share/doc/homebrew/images/brew-test-bot-passed-pr.png
    modified:   share/doc/homebrew/images/brew-test-bot-triggered-pr.png
    modified:   share/man/man1/brew-cask.1
    modified:   share/man/man1/brew.1
    modified:   share/zsh/site-functions/_brew

no changes added to commit
kpete commented 8 years ago

Just curious, what was the original reason for recurse => true, in there? It seems like the formula should decide what perms its own files have... adding or removing execute permissions for packages themselves feels like it could mess with their own functionality... I even caught a crazy edge case with this module where 'watchman' (from facebook's tap) was creating a socket file in /usr/local/var/run, which caused a puppet error while trying to apply those perms (ignore => 'sock', fixed that fine though).

My initial impression is that this should only manage perms for folders above what packages might deploy, but maybe I'm missing some context, since it looks like you used to have it that way. Glad to see you're looking at this!!

jordigg commented 8 years ago

@kpete The recurse true was set to match this suggestions (http://blog.strug.de/2012/06/my-homebrew-multi-user-setup/) among others on how to make it work on a multi-user system. Happy to help correct the needed permissions. @TheKevJames how are you doing on this?

kpete commented 8 years ago

@kpete The recurse true was set to match this suggestions (http://blog.strug.de/2012/06/my-homebrew-multi-user-setup/) among others on how to make it work on a multi-user system. Happy to help correct the needed permissions.

Ahh that makes sense. I'll see if I end up with a situation where the package itself breaks from it, (not just puppet). Thanks!

TheKevJames commented 8 years ago

@jordigg for the most part, I'm blocked on #53 -- the long test cycles and random timeouts have been making this difficult to work on. I think I'll need to look into #53 first, but I've been way too busy lately. Hopefully I'll have some time over the weekend to look into this.

kpete commented 8 years ago

@jordigg The recursive permissions seem to break logrotate. The default config file placed by the formula is in /usr/local/etc/logrotate.conf, and if logrotate is run as root (necessary to be able to rotate logs owned by root) then it returns: Ignoring /usr/local/etc/logrotate.conf because the file owner is wrong (should be root or user with uid 0).

jordigg commented 8 years ago

That makes sense. We should be able to limit the effect of the recurse to a few folders that are really owned by brew. Want to check if it's possible to leave the chmod intact and just rely on the group to allow those members to manage brew in a multi-user environment. I'll finish first with #52 and then work on this.

kpete commented 8 years ago

The change to make the repo location /usr/local/Homebrew in brew 1.0 should help this a lot: https://github.com/Homebrew/install/pull/60/commits/2182f13944db40c11a52ef2b5c9d57b8ea7be384

I'm happy to take a look at this too if time permits. Thanks!

jordigg commented 8 years ago

If homebrew is contained on it's own folder is going to make things easier for everyone. Will check if it's already available and how it effects multi-user setup.

TheKevJames commented 8 years ago

As @kpete remarked, homebrew now installs to /usr/local/Homebrew so this issue was easily solved in #58 . Thanks @kpete and @jordigg for the comments!