search

TheKevJames / puppet-homebrew

homebrew (+brewcask! +taps!) package installer and provider
https://forge.puppet.com/thekevjames/homebrew
Apache License 2.0
18 stars 44 forks source link

re-enable 2.2.3 tests #59

Closed TheKevJames closed 7 years ago

TheKevJames commented 8 years ago

Playground for #48

TheKevJames commented 8 years ago

Looks like only "fast tests" are failing on 2.2.3. This seems related to the recent changes to output parsing/error code capture. I'll be looking into this, but if @jordigg has any thoughts on this, that'd be much appreciated.

jordigg commented 8 years ago

Will look into this asap. Do you know why is trying to test a package called ncl which doesn't exist on brew or brewcask? https://travis-ci.org/TheKevJames/puppet-homebrew/jobs/171291561#L1637

The ones where the build succeeds I don't see ncl anywhere.

edit: I see now is a package from a tap. Didn't see it on the successful builds. Tapping homebrew/science was successful so don't understand why can't find ncl. Did we re-try them? Could it be just a glitch with the package itself not being available during test? Is really weird.

TheKevJames commented 8 years ago

I've been trying a few local builds of this; ncl works in any test on Ruby <=2.1, but fails as soon as we upgrade past 2.2. Still no idea why, but the package itself is installable with latest ruby -- it's definitely a problem with puppet-homebrew.

Ideally, I'd like CI to run against ruby 1.x and ruby 2.2.3 (latest 2.x on TravisCI), since it would be good to have latest for both majors.