search

TheKevJames / puppet-homebrew

homebrew (+brewcask! +taps!) package installer and provider
https://forge.puppet.com/thekevjames/homebrew
Apache License 2.0
18 stars 44 forks source link

Fix homebrew install #64

Closed jordigg closed 7 years ago

jordigg commented 7 years ago

Fixes #63 install left on a weird state + multi-user without recurse on /usr/local

TheKevJames commented 7 years ago

Hey! Thanks for the PR and fixes. Could you explain the difference in behavior between the includes and the new class/contains?

jordigg commented 7 years ago

I was following an example from a similar package (in this case chocolatey) which uses class and contain to better order the resources. It can also be done with anchors. I think my first PR touching the way we execute the install was using this method. Maybe using anchors is more understandable.

To have this installer part completely correct I guess we still need to add params inheritance like I did a few weeks ago, still need to send small PRs for these changes.

http://elatov.github.io/2014/09/writing-better-puppet-modules/

TheKevJames commented 7 years ago

Ah, I get it now. Thanks for the link!