There's an edge case when a tap contains homebrew- on the name that the module will re-add that tap even though is already present. This happens because when brew taps a tap with a name like that, the homebrew- is removed from the name.
To make it easier to understand here an example:
brew tap improbable-io/homebrew-versions
Will result in...
$ brew tap
improbable-io/versions
Therefore when the module checks if a tap is already present by comparing brew tap with the name of the tap we want to add, it will never match.
There are two possible fixes:
Remove homebrew- from any tap name on the puppet manifest.
Make sure the module can support this edge case by comparing against the name and the name minus the homebrew- part.
I think the sane way to proceed is the second one. Will submit a PR.
There's an edge case when a tap contains
homebrew-on the name that the module will re-add that tap even though is already present. This happens because when brew taps a tap with a name like that, thehomebrew-is removed from the name.To make it easier to understand here an example:
brew tap improbable-io/homebrew-versionsWill result in...Therefore when the module checks if a tap is already present by comparing
brew tapwith the name of the tap we want to add, it will never match.There are two possible fixes:
homebrew-from any tap name on the puppet manifest.homebrew-part.I think the sane way to proceed is the second one. Will submit a PR.