search

TheKevJames / puppet-homebrew

homebrew (+brewcask! +taps!) package installer and provider
https://forge.puppet.com/thekevjames/homebrew
Apache License 2.0
18 stars 44 forks source link

Update facts to work in puppet 3 or 4 #69

Closed edestecd closed 7 years ago

edestecd commented 7 years ago

I'm still getting this warning in puppet 4, despite having command line tools installed. warning('No Command Line Tools detected and no download source set. Please set download sources or install manually.')

I think puppet 4 is casting the strings to actual booleans and thus not matching the if == "true". These changes should make the facts behave more predictably and work in either puppet 3 or 4.

TheKevJames commented 7 years ago

Hey there! Thanks for the PR -- I'm currently working on trying to get the testing working properly on this repo, but will take a look at this as soon as that's a bit more settled.

edestecd commented 7 years ago

I've pushed another commit that makes the has_compiler fact work correctly in 10.10 and up

TheKevJames commented 7 years ago

Hey there! Sorry this sat around for so long; those test failures have been a nightmare. Thanks for the PR, looks great.