style(inheritance): remove provider inheritance - Githubissues

TheKevJames / puppet-homebrew

homebrew (+brewcask! +taps!) package installer and provider

https://forge.puppet.com/thekevjames/homebrew

Apache License 2.0

18 stars 44 forks source link

style(inheritance): remove provider inheritance #77

Closed TheKevJames closed 7 years ago

TheKevJames commented 7 years ago

Fuck DRY, brewcommon seems to be causing issues.

Fixes #72 and #73

TheKevJames commented 7 years ago

@jordigg I'd like to cut a new release after merging this PR, but I neither currently have a Mac nor trust the still-broken test suite. Could you checkout this branch and check to make sure everything seems to work?

jordigg commented 7 years ago

I can help with that but tests are still flaky and have no idea why. I just happens randomly with commands that should just work...

jordigg commented 7 years ago

I can confirm everything works as expected.

TheKevJames commented 7 years ago

Thanks a bunch! I still wish we could figure out the tests, but in the meantime, I'll release this.