search

TheKrowi / Krowi_Vendorer

0 stars 0 forks source link

[alpha10] Buyback frame does not respect columns / rows #16

Open filliph opened 1 year ago

filliph commented 1 year ago

I have configured the merchant frame to show 10 Rows / 5 Columns: image

Clicking Buyback shows this: image

Clicking Ignore List immediately afterwards will show the smaller frame: image

vs what I would see if I clicked Merchant first then Ignore List: image

Due to the layout shift, which is universally bad UX, the Buyback frame should respect the Rows / Columns setting.

TheKrowi commented 1 year ago

Reason the buyback frame is not bigger is because you can only get 12 items back so there is no point in making it bigger and showing more items you can;t buy back anyways. The ignore list here however should adhere to the Merchant tab's height.

filliph commented 1 year ago

It still needs to be the same width/height in order to not cause layout shift. It doesn't matter if only 12 items are shown, layout shift is much more disruptive than wondering why no more than 12 items are shown.