TheKrowi / Krowi_Vendorer

1 stars 0 forks source link

"Any" item type #20

Closed filliph closed 1 year ago

filliph commented 1 year ago

Currently, creating a rule that sells all vendor trash items is confusing. In my initial testing, where I had a mix of random items in my inventory found from Expedition Scout Packs and Disturbed Dirt piles, I had to create this rule in order to sell it all:

image

This is because, for some inexplicable reason, some vendor trash items are listed as Consumable. Example: https://www.wowhead.com/item=200807/wooden-ursine-figure

This is not going to be immediately apparent to users. 99% of people just want to automatically sell all grey items, and this add-on comes with a double whammy of no default rule for auto selling greys and requiring us to look up vendor trash on wowhead to figure out why our rule isn't applied.

Personally, as someone who wants to manually vet all grey armour items, I appreciate the granular configuration, but I think that the "Any" item type combined with the Quality = Poor condition should be a default rule to get people started with the add-on.

TheKrowi commented 1 year ago

If you set no item types, all items are evaluated, would that be a solution?

I will add default rules at some point.

filliph commented 1 year ago

I had no idea that's how that worked, might need some way of making that apparent in the UI 😄

TheKrowi commented 1 year ago

I might add a text stating this when no item types are selected. Same for conditions.

TheKrowi commented 1 year ago

image