TheLabbingProject / django_mri

A reusable Django app to manage MRI data.
https://django-mri.readthedocs.io/en/latest/
Apache License 2.0
7 stars 5 forks source link

A working, relatively robust BIDS manager #131

Closed GalKepler closed 2 years ago

GalKepler commented 2 years ago

Finally we've constructed a working BIDS paths constructor for most of the sequences we know. BFFs 4ever - fixed #72

gitguardian[bot] commented 2 years ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Details of the secret
| Secret | Commit | Filename | Detected At | | | ------------------------- | ---------------- | --------------- | -------------------- | -------------------- | | Django Secret Key | c9f346e3a8e8b362c924ce36caf11b363fad6ae7 | tests/test_settings.py | 05:54 November 8th, 2021 | [View secret](https://github.com/TheLabbingProject/django_mri/commit/c9f346e3a8e8b362c924ce36caf11b363fad6ae7#diff-f20069a79c955c52519f37001105df187ba738b9a4dd49af010c723ff810200cL17) |
🛠 How to resolve this 1. Understand the implications of revoking this secret by examining where it is used in your code. 2. Replace and store your secret safely. Learn [here](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/specifics/private_key_openssh#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) 4. If possible, [rewrite your git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to remove all evidence of the secret leak. Please beware this is not a trivial operation. You might completely break other contributing developers’ workflow and you risk accidentally deleting work in progress.

:bulb: To avoid such incidents in the future, consider following these best practices for managing and storing secrets including API keys and other credentials.

You are seeing this because you or someone else has authorized GitGuardian to scan pull requests

codecov[bot] commented 2 years ago

Codecov Report

Merging #131 (7b0e428) into master (bde86a5) will decrease coverage by 3.07%. The diff coverage is 77.35%.

:exclamation: Current head 7b0e428 differs from pull request most recent head f55de62. Consider uploading reports for the commit f55de62 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master     #131      +/-   ##
==========================================
- Coverage   46.85%   43.78%   -3.08%     
==========================================
  Files         186      177       -9     
  Lines        3639     3449     -190     
  Branches      348      317      -31     
==========================================
- Hits         1705     1510     -195     
- Misses       1909     1920      +11     
+ Partials       25       19       -6     
Impacted Files Coverage Δ
django_mri/filters/__init__.py 100.00% <ø> (ø)
django_mri/models/nifti.py 92.72% <ø> (-0.07%) :arrow_down:
django_mri/serializers/__init__.py 100.00% <ø> (ø)
django_mri/urls.py 100.00% <ø> (ø)
django_mri/views/__init__.py 100.00% <ø> (ø)
django_mri/signals.py 46.87% <33.33%> (-1.41%) :arrow_down:
django_mri/utils/bids.py 71.13% <67.92%> (-4.01%) :arrow_down:
django_mri/models/scan.py 61.32% <79.16%> (-1.65%) :arrow_down:
django_mri/admin.py 49.17% <100.00%> (+0.21%) :arrow_up:
django_mri/apps.py 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bde86a5...f55de62. Read the comment docs.