search

TheLabbingProject / django_mri

A reusable Django app to manage MRI data.
https://django-mri.readthedocs.io/en/latest/
Apache License 2.0
7 stars 5 forks source link

Import fix #47

Closed ZviBaratz closed 4 years ago

ZviBaratz commented 4 years ago

Changed get_session() to get_session_by_series() and made it simply return None if no images are associated with the provided series. To compensate for not creating the session in the premature invocation, I added an additional save() call to invoke the signal again after the image is saved. Resolved #46.

codecov[bot] commented 4 years ago

Codecov Report

Merging #47 into master will decrease coverage by 0.29%. The diff coverage is 10.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #47      +/-   ##
==========================================
- Coverage   69.54%   69.24%   -0.30%     
==========================================
  Files         122      122              
  Lines        1619     1626       +7     
  Branches      112      115       +3     
==========================================
  Hits         1126     1126              
- Misses        477      484       +7     
  Partials       16       16
Impacted Files Coverage Δ
django_mri/utils/__init__.py 100.00% <ø> (ø)
django_mri/utils/utils.py 60.52% <6.66%> (-7.13%) :arrow_down:
django_mri/signals.py 48.27% <14.28%> (-5.58%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88907ac...a66c25f. Read the comment docs.