TheLabbingProject / django_mri

A reusable Django app to manage MRI data.
https://django-mri.readthedocs.io/en/latest/
Apache License 2.0
7 stars 5 forks source link

Removed scan information from SessionSerializer #53

Closed ZviBaratz closed 4 years ago

ZviBaratz commented 4 years ago

There was also an issue with django_dicom because of its installation from master and the fixes in it initially not being merged. We should probably also try to move forward to using published versions.

codecov[bot] commented 4 years ago

Codecov Report

Merging #53 (122ad58) into master (e72964e) will increase coverage by 42.60%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #53       +/-   ##
===========================================
+ Coverage   18.65%   61.26%   +42.60%     
===========================================
  Files         140      140               
  Lines        2074     2073        -1     
  Branches      174      174               
===========================================
+ Hits          387     1270      +883     
+ Misses       1687      786      -901     
- Partials        0       17       +17     
Impacted Files Coverage Δ
django_mri/serializers/session.py 100.00% <100.00%> (+100.00%) :arrow_up:
django_mri/signals.py 48.27% <0.00%> (ø)
django_mri/models/sequence_type_definition.py 100.00% <0.00%> (+7.69%) :arrow_up:
django_mri/utils/utils.py 64.28% <0.00%> (+9.52%) :arrow_up:
django_mri/models/session.py 100.00% <0.00%> (+13.33%) :arrow_up:
django_mri/models/sequence_type.py 100.00% <0.00%> (+18.18%) :arrow_up:
...go_mri/analysis/interfaces/mrtrix3/dwigradcheck.py 24.13% <0.00%> (+24.13%) :arrow_up:
django_mri/analysis/interfaces/mrtrix3/mrcat.py 26.19% <0.00%> (+26.19%) :arrow_up:
...jango_mri/analysis/interfaces/mrtrix3/mrconvert.py 28.20% <0.00%> (+28.20%) :arrow_up:
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e72964e...122ad58. Read the comment docs.