Closed dland512 closed 7 years ago
I don't think it's quite right yet. You're "before" example still uses the template
and styles
properties when it should be using templateUrl
and styleUrls
.
Was going to open a PR just for this. It seems wrong to me as well, but of course ... I might be wrong.
The way I see it, readme should look something like:
@Component({
selector: 'awesome-button',
templateUrl: 'button.template.html',
styleUrls: ['button.style.css']
})
export class AwesomeButtonComponent { }
@Component({
selector: 'awesome-button',
template: require('./button.template.html'),
styles: [require('./button.style.css')]
})
export class AwesomeButtonComponent { }
Looking at current specs, my understanding seems to be ok:
@GiuseppePiscopo, that's in line with my understanding as well. Hopefully your PR will get merged soon.
I'm having trouble understanding your documentation. The code snippet given is
But then right below that it says
So why does the example use
template
andstyles
? What am I not getting here?