search

TheLastCrusade / SoundStream

1 stars 6 forks source link

moved special characters to the end #144

Closed ejohnson44 closed 11 years ago

theJenix commented 11 years ago

Doesn't String's built in compareTo function do this? What does it do with special characters?

ejohnson44 commented 11 years ago

It puts them at the beginning, which is why the artist stuff was coming up to the beginning of our lists, not at the end

theJenix commented 11 years ago

I'd like to see if there's a better way to write this comparator...those string matches are really slow, and I don't like the multiple return statements.

ejohnson44 commented 11 years ago

The multiple returns prevent it from doing unnecessary comparisons - I tried to make it compare things as little as possible so that it wouldn't be too time consuming.

I could rewrite it to convert to character arrays and manually compare things, but I think that is essentially what the string compare does anyways.

reidbaker commented 11 years ago

@theJenix What does Elizabeth need to do to get the ok from you?