search

TheLastCrusade / SoundStream

1 stars 6 forks source link

Join as <bluetooth name> in connect fragment #156

Closed reidbaker closed 11 years ago

reidbaker commented 11 years ago

I got this one done first to get back in the swing of coding.

reidbaker commented 11 years ago

connect_as_working

dgreenhalgh commented 11 years ago

Anyone think that this makes more sense with quotes around the name?

Meaning:

Join as "Nexus 4"

rather than

Join as Nexus 4

I believe the default Bluetooth name is the device name, so the fact that the user would be identified by a Bluetooth name rather than a device name may be lost without quotes.

theJenix commented 11 years ago

I think I agree with David...the quotes make sense, as we're specifying a specific string that will be used to identify this phone.

ejohnson44 commented 11 years ago

I agree with the others, but other than that this looks good to me

reidbaker commented 11 years ago

This is now ready to pull in.

theJenix commented 11 years ago

:beers: