search

TheLastCrusade / SoundStream

1 stars 6 forks source link

Fixed numerous issues with sharing state across the network. #213

Closed theJenix closed 11 years ago

theJenix commented 11 years ago

Modified connection workflow so the host transmits a play status message to connecting guests. Guests then set the currentEntry member of PlaylistService and dispatch a play or paused intent to notify the rest of the system.

Refactored PlaybarFragment to listen only to the intents from playlist service (not the messages), and pull current song data from the playlist.

Refactored RemoteAudioPlayer to listen to intents from the playlist service (instead of messages) and update the internal state accordingly.

Fixed a bug where the focus changed listener was being left registered when we recreated an AudioPlayerWithEvents object, leading to weird play/pause behavior.

NOTE: This also seems to have addressed the issue of showing the "now playing" icon on the guest.

fixes #164 fixes #180 fixes #176 fixes #169

reidbaker commented 11 years ago

One formatting nit. @theJenix fix it in some other branch I am pulling this in

reidbaker commented 11 years ago

HEY @TheLastCrusade/owners check this out I was a little over zelous and pulled it in after being the only one to look at it.

dgreenhalgh commented 11 years ago

@reidbaker Any specific concerns or are you just thinking you looked through it too quickly?