search

TheLastCrusade / SoundStream

1 stars 6 forks source link

Need a warning that we're turning on bluetooth #293

Closed theJenix closed 11 years ago

theJenix commented 11 years ago

A couple people have commented that they were surprised that our app automatically turns on bluetooth. Not necessarily in a "oh it shouldn't do that" way, but we probably should put up a small warning that "this app will enable your bluetooth radio."

theJenix commented 11 years ago

I think this falls right in line with our concept of polish, as it reduces user confusion.

dgreenhalgh commented 11 years ago

Is this something that should be added to the first-time-startup instructions?

reidbaker commented 11 years ago

I want to default to Elizabeth on where this should go. I think that not turning on Bluetooth till we need it will help with this as well. That is already another issue. On Aug 13, 2013 4:37 PM, "David Greenhalgh" notifications@github.com wrote:

Is this something that should be added to the first-time-startup instructions?

— Reply to this email directly or view it on GitHubhttps://github.com/TheLastCrusade/SoundStream/issues/293#issuecomment-22599484 .

theJenix commented 11 years ago

Probably so, but I think I like the idea of it in the user's face every time they go to connect a guest or connect to a host. Maybe we can put some fine print in the network fragment? I believe the official Android style guide suggests always asking the user before enabling network adapters like this, but that may be heavy handed.

On Aug 13, 2013, at 5:35 PM, David Greenhalgh wrote:

Is this something that should be added to the first-time-startup instructions?

— Reply to this email directly or view it on GitHub.

dgreenhalgh commented 11 years ago

I think that adding text to the NetworkFragment works well and serves our needs without adding more time to the connection process

theJenix commented 11 years ago

This is addressed in pull request #308, which adds a dialog box to ask the user whenever we need to enable bluetooth. Care was taken to match the style of other similar dialogs (such as when Google Maps asks to enable wifi or GPS), as much as possible.