search

TheLastCrusade / SoundStream

1 stars 6 forks source link

Fixed a bug with cleaning up state after a network is disbanded #332

Closed theJenix closed 10 years ago

theJenix commented 10 years ago

In an attempt to reproduce #245, I noticed that the guest was not being cleaned up properly. This should fix that.

theJenix commented 10 years ago

This is forked off of cancel_partial. We should probably pull that in first.

reidbaker commented 10 years ago

Will wait till cancel_partial is pulled in to review

dgreenhalgh commented 10 years ago

I reviewed this pull request using #330 as a reference because of how much overlap there is between the code. A couple of the issues seem to have been fixed in #330 but just haven't been merged in to this yet.

theJenix commented 10 years ago

Just merged in master (which includes #330). This should be much easier to review now.

dgreenhalgh commented 10 years ago

:+1: