gpth unable to get date for files with parentheses

[casualsailo]

Hello,

I tried using this tool and found that there was certain files that the program wasn't able to get dates for. Here's a small snippet of the warning messages

Can't get date on ..\Takeout\Google Photos\Photos from 2019\image(10).jpg

Can't get date on ..\Takeout\Google Photos\Photos from 2019\image(11).jpg

Can't get date on ..\Takeout\Google Photos\Photos from 2019\image(12).jpg

Can't get date on ..\Takeout\Google Photos\Photos from 2019\image(13).jpg

Can't get date on ..\Takeout\Google Photos\Photos from 2019\image(14).jpg

Can't get date on ..\Takeout\Google Photos\Photos from 2019\image(15).jpg

When I checked the folder, I noticed the corresponding json file was named differently. The item in parentheses is being placed after the original file extension

image(10).jpg image(11).jpg image(12).jpg image(13).jpg image(14).jpg image(15).jpg image.jpg(10).json image.jpg(11).json image.jpg(12).json image.jpg(13).json image.jpg(14).json image.jpg(15).json

If I manually rename the image.jpg(10).json file to image(10).jpg.json, the program is able to get the date. Would it be possible to update the program to work for file names with parentheses?

[TheLastGimbus]

huh... this was carefully observed in #175

seems like, altough i strip (n) in photo names, this does not find the proper json in this case... hmmm

i may add another extractor that will try to link this... i will follow here when i'm done - please be here to test it then ;)

tldr:

Would it be possible to update the program

yes, i will try :)

[TheLastGimbus]

meanwhile, could you help me with testing album support in #187 ? this would speed whole developlent up!

[casualsailo]

Thank you for your hard work on this tool. I used your tool once mid 2022 and am glad to see that you are still actively updating it after all this time. I just sent you a small donation!

I personally don't use google photos, but my less tech-savvy family members do. Because google no longer gives free unlimited storage for "high quality", I needed to download the files to free up google storage space

But the downloaded files are a mess! Files don't have the correct date modified, files are scattered in the wrong order in one giant folder (since it's sorted by name instead of date), etc.

Your tool is perfect for the job of organizing the files (using divide-to-dates)! I just wanted to let you know my appreciation for your work

They don't use albums, so I unfortunately can not help you with the testing

[TheLastGimbus]

whoa, that's very heartwarming to read 😊😊😊 and thx for the 💸 - they really help me going, and even recenlty bught myself the Nintendo Switch 🎮 - helps doze off my brain in programming breaks 🤤

They don't use albums, so I unfortunately can not help you with the testing

oh the album branch contains some refactors, and also trash/archive are also albums - if you could just run the tool and comfirm it's not crashing, that would also be help me a lot!

[casualsailo]

Around 10,000 photos/videos. There are no crashes. The archive/trash folder isn't causing any issues

[TheLastGimbus]

The archive/trash folder isn't causing any issues

and it is there, nicely detected and contains photos that were there?

[casualsailo]

I spot checked a few photos, and it does seem like it moved correctly. Files also have their date modified

[TheLastGimbus]

so i did a thing :eyes:

look up to the next relese soon

you can also download this nightly build test it: https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/4578496717