TheLastGimbus / GooglePhotosTakeoutHelper

Script that organizes the Google Takeout archive into one big chronological folder
https://aur.archlinux.org/packages/gpth-bin
Apache License 2.0
3.48k stars 176 forks source link

Fix extra files not being recognized on MacOS #247

Closed TheLastGimbus closed 9 months ago

TheLastGimbus commented 9 months ago

A bit of comment for future generations:

As @palijn nicely summarised it - "Linux file systems use NFC where MAC FS choose NFD" - which, said NFD, doesn't == accents and other unicode stuff with our extras collection

This caused #204 (we didn't have separate -modife then but I added regex option that still didn't work), then #243, and probably few other issues

I really thought we had all of the "encoding something something" nightmare resolved ages ago -_-

So, merging this closes #243 :)

TheLastGimbus commented 9 months ago

hey

hey

@palijn

...i'm done :eyes:

try it on your blazing fast M1: https://github.com/TheLastGimbus/GooglePhotosTakeoutHelper/actions/runs/6280457253

...also, if you could test out if this doesn't break stuff on linux or especially windoza, i would be grateful :pray:

palijn commented 9 months ago

Tested successfully on my blazing fast M1. Great job !

(For the record , 4169 photos with 19 albums processed in 7,56s ).

I can't test on W*s, sorry.

TheLastGimbus commented 9 months ago

7,56s

7,56s

7,56s

DAMN