TheLastGimbus / GooglePhotosTakeoutHelper

Script that organizes the Google Takeout archive into one big chronological folder
https://aur.archlinux.org/packages/gpth-bin
Apache License 2.0
3.88k stars 192 forks source link

OS Error: The system cannot move the file to a different disk drive #326

Closed stantaneous closed 1 month ago

stantaneous commented 3 months ago

I am facing this error with the version v3.4.3.

For my input folder, I am choosing the folder from D: drive and for the output folder, I am choosing the folder on C: drive. Looks like the script is not able to move the files from D: drive to C: drive.

image

I guess I can fix this by choosing the folder from same drive. However, it would be better to have a fix for this error. It might be helpful to choose to different drive for output in case the input drive does not have space available.

palijn commented 3 months ago

I am not sure this is really adviseable. It's nice that gpth is extremely fast and robust because it moves the file within the same filesystem, which actually doesn't move any data. Moving across filesystems always is a copy followed by a delete : much slower and prone to errors.

stantaneous commented 3 months ago

It should work to move files to different partition drive with same file system. I can understand that it might not be advisable, it would be better to not allow the user to choose the output folder from different file system in the first place or show the error messages in the end. I could only see the error message when i ran the application though terminal. It just crashed if we run it interactively without showing any errors.

TheLastGimbus commented 1 month ago

duplicate of #251

it would be better to not allow the user

yeah that's something to consider, thanks!