TheLastProject / RaiseToAnswer

Simply hold your phone to your ear to answer an incoming call
https://play.google.com/store/apps/details?id=me.hackerchick.raisetoanswer
MIT License
74 stars 13 forks source link

Android 7 #10

Open zekooooo opened 4 years ago

zekooooo commented 4 years ago

Hello, this app looks very useful! Any possibility of adding support for Android 7?

Edit: Sorry for multiple posts looks like the app with which I'm accessing Github is broken :(

TheLastProject commented 4 years ago

Well, the main issue is that I use 2 functions that were only introduced fairly recently:

[acceptRingingCall](https://developer.android.com/reference/android/telecom/TelecomManager#acceptRingingCall()) - API level 26 (Android 8) [endCall](https://developer.android.com/reference/android/telecom/TelecomManager#endCall()) - API level 28 (Android 9)

Because of that, the app needs at least Android 8. All the other code should work find on older devices though.

These two functions are deprecated in API level 29 again, so I'm going to have to replace them at some point (not sure with what yet), but it's really up to Google above all what Android versions I can support. That being said, if you find a nice and reliable way to do this I'm welcome to hearing about it.

mspeace commented 3 years ago

lol i went here to ask why it's not on a Android 5

TheLastProject commented 3 years ago

If someone contributes code to make it work on older Android versions that doesn't break support for newer Android versions I am willing to accept it.

mspeace commented 3 years ago

a living legend.

2020-11-13 15:01 GMT+02:00, Sylvia van Os notifications@github.com:

If someone contributes code to make it work on older Android versions that doesn't break support for newer Android versions I am willing to accept it.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/TheLastProject/RaiseToAnswer/issues/10#issuecomment-726751794

TheLastProject commented 3 years ago

It seems that InCallService supports API level 23, which is Android 6.0. So Android 6 and up support should be possible after #34 (sadly no Android 5).