search

TheLastScrub / delta-green-foundry-vtt-system-unofficial

A Foundry VTT game system for Delta Green: The RPG! This is a fan made work that is unaffiliated with Shane Ivey or Arc Dream Publishing, published under the Delta Green Community license. http://www.delta-green.com https://foundryvtt.com/
MIT License
25 stars 23 forks source link

German Translation and Luck-Translate Error Message #100

Closed KarstenW76 closed 5 months ago

KarstenW76 commented 6 months ago

Thank you for building up the system, so far (I'm new to Delta Green) it looks very good and seems to work fine. Thank you!

I see, you added some translations and I created (and already verified) a translation to German (DE-Deutsch). It would be awesome, if you add it:

de.json

With the translations I found a small error, one translation key is missing:

Bildschirmfoto 2023-12-22 um 12 31 14

The keys are already in the master (en.json) and I translated them to de.json. The execution of the luck roll in the Chat is correct via the both keys. But when hovering over the icon for Luck roll execution, the English "Roll Luck" is shown. I think, here must be a small mistake or missing key.

Bildschirmfoto 2023-12-22 um 12 34 33

Thank you for checking in advance! I wish you merry Christmas! Kind regards, Karsten

jalensailin commented 6 months ago

Thanks for the kind comments! We will definitely look into getting these changes integrated. Are you familiar with Git or GitHub at all? If you want, you could just open a Merge Request with the updated json but no worries if not.

KarstenW76 commented 6 months ago

Sorry, not so really, never merged anything. Would be perfect, if you check to add it by next ocation. For the meantime and myself I made up a module for the translation (for myself). Thank you!

TheLastScrub commented 5 months ago

@KarstenW76 @jalensailin

I snuck this into v.1.4.2 since I was packing it up to address a bug Jalen fixed anyways. Let me know if you have any issues with it.

I couldn't reproduce the issue with the tool tip on the luck roll though. As far as I can tell there shouldn't even be a tooltip there in the first place. So not sure where that is coming from. I'm going to close this for now, but feel free to re-open an issue if there is more to add.