search

TheLastScrub / delta-green-foundry-vtt-system-unofficial

A Foundry VTT game system for Delta Green: The RPG! This is a fan made work that is unaffiliated with Shane Ivey or Arc Dream Publishing, published under the Delta Green Community license. http://www.delta-green.com https://foundryvtt.com/
MIT License
25 stars 23 forks source link

sort skills in character sheet like in the PDF #101

Closed stories-with-dice closed 3 months ago

stories-with-dice commented 5 months ago

Hello,

Currently the skills in the Character sheet are sorted by row, not by column. This is confusing. It should be like in the PDF, to maintain compatibility and easier reading.

Compare

Foundry

image

PDF:

image

16-Bits commented 4 months ago

I've got it sort of working on my own fork of the system but ran into graphical issues when hiding skills on the NPC sheet. I don't have a good understanding of how hiding the skills work and have been busy lately so I've been unable to develop it any further. Would appreciate it if someone could have a look and help me with it. Player sheet example image NPC sheet example image NPC sheet with hidden skills image

stories-with-dice commented 4 months ago

That looks good to me!

What is the graphical issue?

16-Bits commented 4 months ago

The column should collapse and keep each skill in their original column, or all the skills should be evenly distributed among the 3 columns in my opinion.

jalensailin commented 4 months ago

Hi! One of the devs here. Thanks for doing this work :). I think I have found a simpler solution that takes care of the graphical issue that you spoke of. it just requires a few lines change of code. ill be posting an MR soon. Let me know what you think.

EDIT: I suppose that it doesn't address the graphical issue with the solution you described, maintaining 3 columns and keeping each skill in its original column. Doing this would be fairly complicated as far as I can tell. I think I am fine with my solution, at least for now, as it doesn't just leave unused space on the sheet.

NPC - All Skills Shown: image

NPC - Skills Hidden: image

16-Bits commented 4 months ago

Looks good to me, it's so much easier to find and read skills by just going down a column as opposed to rows