search

TheLastScrub / delta-green-foundry-vtt-system-unofficial

A Foundry VTT game system for Delta Green: The RPG! This is a fan made work that is unaffiliated with Shane Ivey or Arc Dream Publishing, published under the Delta Green Community license. http://www.delta-green.com https://foundryvtt.com/
MIT License
25 stars 23 forks source link

V12 compatibility #115

Closed drewg13 closed 4 weeks ago

drewg13 commented 1 month ago

You're going to want to drop a maximum core version of 11 on your most recent release (perhaps on all your older listed releases as well), as this system will successfully download or update in V12, but character sheets will not open. You can just do this through the package management interface, so it should just take a minute.

Yes, users should wait to update core, but preventing them from installing a version that will not work will help also.

jalensailin commented 1 month ago

Hey thanks for bringing this up. Will try to address this as soon as possible

drewg13 commented 1 month ago

Oof, it's still installable in V12, looks like that just pushed the version offered back to 1.4.3, the first version without a max set. That means you probably need to put a max core of 11 on all your available releases, unfortunately. To be clear, this is about preventing update-related support headaches as a fellow system dev, not about pressure to put out a compatible version.

andrewbeard commented 1 month ago

I'm getting these warnings on v12:

The system "deltagreen" is using "gridDistance" which is deprecated in favor of "grid.distance".
The system "deltagreen" is using "gridUnits" which is deprecated in favor of "grid.units".

The fix for this (without breaking v11) involved defining it both the old way AND the new way. I can put up a PR in a bit.

andrewbeard commented 1 month ago

Just added PR #117 to fix the grid warnings

jalensailin commented 1 month ago

There are several issues that we identified in the transition to v12. We are currently working on those issues but it could still be some time.

ericcberg commented 1 month ago

Putting this here in case it is not already known, but Agent sheets aren't working.

Error: An error occurred while rendering DeltaGreenActorSheet 60. One of original or other are not Objects! at Hooks.onError (foundry.js:630:24) at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22) at 🎁Hooks.onError#lib-wrapper (listeners.js:138:11) at 🎁Hooks.onError#0 (libWrapper-wrapper.js:187:52) at foundry.js:5771:13Caused by: Error: One of original or other are not Objects! at mergeObject (foundry-esm.js:3324:13) at _mergeUpdate (foundry-esm.js:3388:14) at mergeObject (foundry-esm.js:3345:41) at _mergeUpdate (foundry-esm.js:3388:14) at mergeObject (foundry-esm.js:3345:41) at _mergeUpdate (foundry-esm.js:3388:14) at Object.mergeObject (foundry-esm.js:3345:41) at DeltaGreenActorSheet._render (foundry.js:5807:19) at DeltaGreenActorSheet._render (foundry.js:6548:17) at DeltaGreenActorSheet._render (foundry.js:7134:17) at DeltaGreenActorSheet.render (foundry.js:5769:10) at Token._onClickLeft2 (foundry.js:60839:17) at MouseInteractionManager.callback (foundry.js:30532:17) at #handleClickLeft2 (foundry.js:30755:15) at #handleLeftDown (foundry.js:30714:83) at #handlePointerDown (foundry.js:30679:58) at vh.notifyListeners (EventBoundary.ts:1454:26) at vh.notifyTarget (EventBoundary.ts:662:18) at vh.propagate (EventBoundary.ts:299:14) at vh.dispatchEvent (EventBoundary.ts:210:14) at vh.mapPointerDown (EventBoundary.ts:683:14) at vh.mapEvent (EventBoundary.ts:231:28) at ra.onPointerDown (EventSystem.ts:373:31)

tobifroe commented 1 month ago

There are several issues that we identified in the transition to v12. We are currently working on those issues but it could still be some time.

@jalensailin Will you create issues for the mentioned problems? Would love to help.

jalensailin commented 1 month ago

We have already fixed them :). Just have to cut a release

jalensailin commented 1 month ago

Putting this here in case it is not already known, but Agent sheets aren't working.

Error: An error occurred while rendering DeltaGreenActorSheet 60. One of original or other are not Objects! at Hooks.onError (foundry.js:630:24) at 🎁call_wrapped [as call_wrapped] (libWrapper-wrapper.js:507:22) at 🎁Hooks.onError#lib-wrapper (listeners.js:138:11) at 🎁Hooks.onError#0 (libWrapper-wrapper.js:187:52) at foundry.js:5771:13Caused by: Error: One of original or other are not Objects! at mergeObject (foundry-esm.js:3324:13) at _mergeUpdate (foundry-esm.js:3388:14) at mergeObject (foundry-esm.js:3345:41) at _mergeUpdate (foundry-esm.js:3388:14) at mergeObject (foundry-esm.js:3345:41) at _mergeUpdate (foundry-esm.js:3388:14) at Object.mergeObject (foundry-esm.js:3345:41) at DeltaGreenActorSheet._render (foundry.js:5807:19) at DeltaGreenActorSheet._render (foundry.js:6548:17) at DeltaGreenActorSheet._render (foundry.js:7134:17) at DeltaGreenActorSheet.render (foundry.js:5769:10) at Token._onClickLeft2 (foundry.js:60839:17) at MouseInteractionManager.callback (foundry.js:30532:17) at #handleClickLeft2 (foundry.js:30755:15) at #handleLeftDown (foundry.js:30714:83) at #handlePointerDown (foundry.js:30679:58) at vh.notifyListeners (EventBoundary.ts:1454:26) at vh.notifyTarget (EventBoundary.ts:662:18) at vh.propagate (EventBoundary.ts:299:14) at vh.dispatchEvent (EventBoundary.ts:210:14) at vh.mapPointerDown (EventBoundary.ts:683:14) at vh.mapEvent (EventBoundary.ts:231:28) at ra.onPointerDown (EventSystem.ts:373:31)

Can you please check with no modules enabled? Is this a fresh world or an existing world?

TheLastScrub commented 4 weeks ago

I was trying to see if I could make a release that was compatible with v11 and v12, but couldn't quite get it to be backwards compatible. I did however just publish the v12 compatible branch (v1.4.5) flagged as being only compatible with v12. I think this should resolve a couple of issues, but let us know if you are still seeing issues after upgrading to the latest system.