search

TheLastScrub / delta-green-foundry-vtt-system-unofficial

A Foundry VTT game system for Delta Green: The RPG! This is a fan made work that is unaffiliated with Shane Ivey or Arc Dream Publishing, published under the Delta Green Community license. http://www.delta-green.com https://foundryvtt.com/
MIT License
25 stars 23 forks source link

Fix private san rolls #89

Closed jalensailin closed 9 months ago

jalensailin commented 9 months ago

NOTE: Leaving as draft until PR #88 is merged

Issue #87 brought up that San rolls are not actually enforced to be private currently. This MR fixes that.

Steps to test:

  1. Checkout this branch
  2. Log into Foundry as a GM
  3. Open the settings and select "Keep Sanity Private"
  4. Open an incognito window, and login as a player. Assign an actor to the player.
  5. As a player, open actor sheet and ensure that SAN and Ritual are ??. GM should still be able to see everything.
  6. As a player, roll SAN. Player should see image
  7. As a player, roll Ritual. Player should see the same as above.
  8. Shift-click and roll to open the modifier dialog. Player should see image
  9. Try changing roll type to Public or any non-blind GM roll. Ensure that the roll is forced to be Blind GM Roll no matter what.
  10. Repeat steps 8-9 with the Ritual skill.
  11. Roll other skills/weapons/damage (with and without modification dialog) and make sure players can see their numbers (no ??)