search

TheLastScrub / delta-green-foundry-vtt-system

A Foundry VTT game system for Delta Green: The RPG! This is a fan made work that is unaffiliated with Shane Ivey or Arc Dream Publishing, published under the Delta Green Community license. http://www.delta-green.com https://foundryvtt.com/
MIT License
27 stars 24 forks source link

Foundry v11 Compatibility #71

Closed rnadams2 closed 1 year ago

rnadams2 commented 1 year ago

Can we expect an update soon? I'm currently running a game in Foundry with a few others in different systems, and I'd like to install the updates for those, as well as any modules that have been updated.

TheLastScrub commented 1 year ago

Are you aware of any specific compatibility issues, or just asking when the system will be flagged as v11 compatible?

Not sure exactly when I'll put out a new package, but in limited testing I've not seen any issues with the system in v11.

rnadams2 commented 1 year ago

I've been holding out on upgrading for fear that my campaign may break. I was of the understanding (erroneously, I guess) that the DB change in the new version would cause more problems than it seems to be. I'll keep an eye out here and see if anyone brings up any issues, and upgrade eventually if nothing pops up.

Thanks!

tompudding commented 1 year ago

One thing I noticed is that the "Apply Skill Improvement" button seems to only work for one skill in v11. It rolls for all of them, but only one gets unchecked and increased. Clicking it n times does the trick though!

TheLastScrub commented 1 year ago

@tompudding Looking at it, kind of surprised the behavior on this would be any different in v10 than v11. But I think I know how to resolve it.

@jalensailin I will make a change to _applySkillImprovements() so that all the skill updates to the actor happens in one call synchronously (as opposed to doing each skill individually in the loop). In my v11 test environment, it seems to work.

I've seen issues like this before where because multiple updates are all happening async, only the last update goes through and wipes all the changes before it. If you think there is a more elegant way to do it though, feel free to modify it.

jalensailin commented 1 year ago

@TheLastScrub

Sounds good, thanks for the update and apologies for introducing an error!

heliobolseiro commented 1 year ago

How do I convert Delta Green to Portuguese?

jalensailin commented 1 year ago

@heliobolseiro Okay, it seems that portuguese is supported but there is a bug causing it not to render when selected. looking into it. opening an issue to track that specifically