TheLastScrub / delta-green-foundry-vtt-system

A Foundry VTT game system for Delta Green: The RPG! This is a fan made work that is unaffiliated with Shane Ivey or Arc Dream Publishing, published under the Delta Green Community license. http://www.delta-green.com https://foundryvtt.com/
MIT License
27 stars 24 forks source link

Roll Refactor | Sheet Restyle #85

Closed jalensailin closed 1 year ago

jalensailin commented 1 year ago

This PR does a number of things:

Steps to test:

For all rolls, try rolling a few to make sure all the combinations work (critical success, regular success, regular fail, and critical fail).

  1. Roll stats
    1. Roll unmodified stat
    2. Roll modified stat
    3. Roll inhuman stat (stat > 20) and make sure it follows all the rules
    4. Check chat cards (expanded and not expanded) and make sure they look good.
  2. Roll skills
    1. Roll unmodified skill
    2. Roll unmodified typed skill
    3. Roll modified skill
    4. Roll unmodified typed skill
    5. Check chat cards (expanded and not expanded) and make sure they look good.
  3. Roll Luck check, modified and unmodified
  4. Roll a Sanity check, modified and unmodified
  5. Roll weapons
    1. Roll weapon attack (using a skill for the target) modified and unmodified
    2. Roll regular damage modified and unmodified
    3. Roll regular damage with a math function in the formula
    4. Roll lethality damage modified and unmodified
    5. Repeat steps 5.1-5.4 using a stat x5 for the target
    6. Repeat steps 5.1-5.4 using a custom target
    7. Repeat steps 5.1-5.4 with a modifier on the weapon item.
    8. Check chat messages for 5.1 - 5.7.
  6. Repeats steps 1-5 on NPC and Unnatural sheets (if applicable).
  7. On an unnatural sheet, roll sanity damage. Check chat message
  8. On NPC/Unnatural sheets, click the "eye" glyph to toggle the display of untrained skills.