search

TheLethalCode / Artemis-arrow

14 stars 31 forks source link

Anime List generated by BeautifulSoup #27

Closed CircleJerkHug closed 5 years ago

CircleJerkHug commented 5 years ago

Fetched and scraped data from [myanimelist.net/anime/(some value)/] from BeautifulSoup and request module. The pages was quite a large in number, so, having a low internet speed I collected data from 20 pages and it goes very well for more. Also, handled the exception when the page is not found which was quite frequent. Collected the data such as Name of the Anime, Rating, Description, Ranking and Number of episodes. Also, stored the data in anime_scrape.json file to be used furthur.

TheLethalCode commented 5 years ago

This is good, but you are running your code in python2, but we are using python3. Would be better if you make the code python3 compatible. One more thing, though you have used functions, your for loop is still in the global space. Place the 'for' loop under the main, and leave the info_anime in the global namespace.

CircleJerkHug commented 5 years ago

The suggested changes are made. Ready to be merged.

TheLethalCode commented 5 years ago

Hey, you have sent the PR to the wrong branch. Resend it to the devel branch