TheLocehiliosan / yadm

Yet Another Dotfiles Manager
https://yadm.io/
GNU General Public License v3.0
4.92k stars 176 forks source link

Cannot set Arch Linux as distro_family #426

Closed sinus-x closed 1 year ago

sinus-x commented 1 year ago

Hi. Today I found out that it's not possible to set arch as distro family. My wild guess is that's it is also keyword for architecture.

$ touch textfile.txt##default
$ yadm add textfile.txt##default
$ touch textfile.txt##distro_family.arch
$ yadm add textfile.txt##distro_family.arch
**WARNING**
  Invalid alternates have been detected.

  Beginning with version 2.0.0, yadm uses a new naming convention for alternate
  files. Read more about this change here:

    https://yadm.io/docs/upgrade_from_1

  Or to learn more about alternates in general, read:

    https://yadm.io/docs/alternates

  To rename the invalid alternates run:

    yadm mv <old name> <new name>

  Invalid alternates detected:
    * /home/u/.dotfiles/textfile.txt##distro_family.arch

***********

and the same for short-form ##f.arch.

Setting uppercase Arch in filenames works, but that won't get matched as family.

TheLocehiliosan commented 1 year ago

@sinus-x What version of yadm are you using? I suspect you're using a version that does not support distro_family. What's the output of yadm version?

distro_family support started with version 3.2.0

sinus-x commented 1 year ago

Ah damn, sorry, I did not realize Ubuntu 20.04 still had 2.x branch. That would explain that.

For future features, would it be possible to add some little note to the documentation ("Introduced in version 3.2")? That would hint the users to check their local versions before they open an issue like I did :upside_down_face: Thanks for the yadm, it solved so much of my problems! :grinning:

bcdady commented 1 year ago

Hi @sinus-x, I see it's mentioned here: CHANGES # 3.2.0. Is there other 'documentation' you think it should be added to?

sinus-x commented 1 year ago

I was mainly referring to the website, as that's how I learned about alternate files and most of the features.

image

^^ This is my idea of a way how to do that, you could surely find one that would fit your style. The CHANGES file is nice, but I don't believe it would be on top of the list to look at when something is not working.