Now WebView automatically removes 'Download Android App' button on the top of Website

TheM4hd1 / SwiftyInsta

Instagram Private API Swift

MIT License

225 stars 51 forks source link

Now WebView automatically removes 'Download Android App' button on the top of Website #127

Closed swifty-things closed 4 years ago

swifty-things commented 4 years ago

TheM4hd1 commented 4 years ago

@sbertix can you check this?

sbertix commented 4 years ago

The code is actually correct @TheM4hd1
The problem is with Travis CI, it's one of the fixes in #96, which should now be done, btw 😊

The only thing is that this fix still seldomly causes a blank page to appear instead of logging the user in when tapped the button, which was why I removed this feature before getting 2.0 up to everybody, if you recall.
I wouldn't merge this until we actually find a way to make this 100% reliable imho.

TheM4hd1 commented 4 years ago

correct, we had this feature before, but it causes issues. let's postpone it for now. when we find a stable version, we will add it. Thanks