TheMaverickProgrammer / OpenNetBattle

An open source card-based battle engine written in modern C++
GNU General Public License v3.0
197 stars 41 forks source link

Artifacts possibly updating twice in a single frame #230

Closed TheMaverickProgrammer closed 1 year ago

TheMaverickProgrammer commented 1 year ago

see video on discord

When some update starts up again or stops (perhaps battlestep?), it appears than an artifact may update twice within a single frame. After timefreeze ends, starts, or when we exit the Custom widget, there is an extra artifact update tick occurring.

We should also ensure that all other entity types are also only happening once per frame. (NOTE: It's possible battlescene.update(0) is the culprit which is used to refresh sprites but also incurs an update tick, when it shouldn't.