search

TheMightyPenguin / dessert-box

An utility to create a Box component from your vanilla-extract + sprinkles tokens.
MIT License
343 stars 20 forks source link

Add missing destructuring to createBox statement in readme #9

Closed Seam7 closed 3 years ago

TheMightyPenguin commented 3 years ago

Thanks for the contribution!! 🎉🎉💯

jose-landero commented 3 years ago

@TheMightyPenguin Sorry for the comment on a merged PR, but I think that the return of createBox doesn't need to be destructured

TheMightyPenguin commented 3 years ago

@TheMightyPenguin Sorry for the comment on a merged PR, but I think that the return of createBox doesn't need to be destructured

Hey @jose-landero ! It was actually needed on a previous version of the library as we actually returned an object, but not anymore, we refactored the API yesterday. But this was needed as we were actually returning an object!

You can see the commit where the API did return an object here https://github.com/TheMightyPenguin/dessert-box/commit/93ab42af1afa43b289550142ef5d1eb97f1976cc

jose-landero commented 3 years ago

Oh! I see, that's why I get confused 😅 Thanks, awesome work!

TheMightyPenguin commented 3 years ago

Oh! I see, that's why I get confused 😅 Thanks, awesome work!

@jose-landero thank you haha it makes me happy to see people using this project and looking around in the repository! 🙌