TheMinusWorld / forum-improvements

Organize suggestions and other details related to improving the phpBB iteration of the Minus World
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Imported: Remove colon from quote box #75

Open wtl420 opened 8 years ago

wtl420 commented 8 years ago

Need a better solution than just js replace

Sat Dec 06, 2014 06:24 PM Remove the colon from the quote box by Bitteh:

Quote boxes have already been improved thanks to me by removing the "wrote" but I also think the colon should be removed because it looks ugly if you make the person being quoted into a hyperlink. Example:

Ika Musume:

I had to crop due to ass cleavage (although she was wearing something) but at least I got the important part, the toucan.

It looks bad because the colon is a different font from the hyperlink. (It doesn't look TOO bad on the default skin but it looks especially bad on skins like HaunterBerry. Screenshot.)

pros to removing colons from quote boxes

  • quotes with hyperlinks in the title look less ugly

cons to removing colons from quote boxes

Sat Dec 06, 2014 06:26 PM Re: Remove the colon from the quote box by World'sTallestLadder:

Excellent suggestion. +1 LOL

Sat Dec 06, 2014 06:28 PM Re: Remove the colon from the quote box by Draku:

While I will agree that it looks a little off with a hyperlink, the colon works well as a signal of it being a quote. It begins to look too much like loose text otherwise, depending on the skin you use.

Sat Dec 06, 2014 06:29 PM Re: Remove the colon from the quote box by Bitteh:

Draku:

While I will agree that it looks a little off with a hyperlink, the colon works well as a signal of it being a quote. It begins to look too much like loose text otherwise.

If you don't put a name in the quote it automatically adds the word "quote"

Quote:

example

also

Draku:

depending on the skin you use.

I don't know what you mean exactly as long as it either has the person's name or "quote" on the top

Sat Dec 06, 2014 06:32 PM Re: Remove the colon from the quote box by Draku:

Ika Musume:

If you don't put a name in the quote it automatically adds the word "quote"

I know that, but on a skin like Megaman the name and quote box are separate so you'd just have the member name floating above the quote box. It's still discernible but it looks strange to say the least which is why this suggestion was made in the first place.

Sat Dec 06, 2014 06:34 PM Re: Remove the colon from the quote box by Bitteh:

Oh. Well is it possible to make quoteboxes behave differently on different skins?

Sat Dec 06, 2014 06:42 PM Re: Remove the colon from the quote box by Draku:

Ika Musume:

Oh. Well is it possible to make quoteboxes behave differently on different skins?

It might be possible with an extremely odd workaround using the skin files to have something that scans for it, though that'd be kind of extreme.

Given that there -is- at least some distinction made with the font used for the quote title text even on skins that have quote boxes that behave as I said, I don't think it'd be too bad to try it and see if there are any complaints from other users. I don't think I can edit the base bbcode stuff without FTP access though now that I think about it, so I'll have to bother Elyk about doing so.

Sat Dec 06, 2014 09:44 PM Re: Remove the colon from the quote box by World'sTallestLadder:

here's a javascript snippit that removes the colon from all quote boxes except when its just "Quote:" (I can remove that too, but its a bit more code fsr and who cares)

Code:

quote_titles = document.querySelectorAll('.quotetitle');
for (var i = 0; i < quote_titles.length; ++i)
quote_titles[i].innerHTML = quote_titles[i].innerHTML.replace(/:$/,'');

add it somewhere in the html as

Code:

or in a .js file included by the skins.

Should this be done by JavaScript? not really. but w/e

Tue Dec 09, 2014 01:36 AM Re: Remove the colon from the quote box by Elyk:

I tried editing the .php files. It will take a while for the change to be visible because of Cloudflare.

If everything becomes @!$% up I'll return it to how it was.

Tue Dec 09, 2014 08:18 AM Re: Remove the colon from the quote box by Elyk:

I don't think it did anything.

Tue Dec 09, 2014 04:41 PM Re: Remove the colon from the quote box by Spritey:

You guys can do this easily with just CSS if editing the templates is a pain:

Code:

.quotetitle {
visibility: hidden;
}

.quotetitle > a {
visibility: visible;
}

It's hacky, but hey, this is a table-based site. The whole thing is one big hack.

EDIT: Actually no, only the quote box in the OP has a link. I was under the impression that they all did.

Tue Dec 09, 2014 07:12 PM Re: Remove the colon from the quote box by World'sTallestLadder:

tbh ideally the quotes would auto-magically link back to the original post, which many forum softwares do.

Tue Dec 09, 2014 07:22 PM Re: Remove the colon from the quote box by Draku:

World'sTallestLadder:

tbh ideally the quotes would auto-magically link back to the original post, which many forum softwares do.

There are some quote backlink mods for phpBB that I would like to see implemented, myself.

By the way I implemented that javascript bit since none of the other solutions worked and it appears to function fine. If something breaks let me know.