[Bug] Server launch, but "Offline player could not be created."

[Tellsanguis]

Describe the bug The command doesn't work and no player is spawning.

To Reproduce Steps to reproduce the behavior:

1. Change "autoDisconnect" to false (don't know if it's important).
2. Try the command "/offline" and variants (/offline attack:20, eat...)
3. Get "Offline player could not be created."

Expected behavior A fake player supposed to spawn.

Logs

java.lang.NullPointerException: null at java.base/java.util.Objects.requireNonNull(Objects.java:233) ~[?:?] at com.misterfish.patch.OfflinePlayer.createAndSpawnNewOfflinePlayer(OfflinePlayer.java:84) ~[offlineplayersreworked-1.0.3.jar:?] at com.misterfish.OfflinePlayersReworked.spawn(OfflinePlayersReworked.java:138) ~[offlineplayersreworked-1.0.3.jar:?] at com.misterfish.OfflinePlayersReworked.lambda$onInitializeServer$0(OfflinePlayersReworked.java:74) ~[offlineplayersreworked-1.0.3.jar:?] at com.mojang.brigadier.context.ContextChain.runExecutable(ContextChain.java:73) ~[brigadier-1.2.9.jar:?] at net.minecraft.class_8865.method_54416(class_8865.java:29) ~[server-intermediary.jar:?] at net.minecraft.class_8865.execute(class_8865.java:13) ~[server-intermediary.jar:?] at net.minecraft.class_8856.method_54405(class_8856.java:8) ~[server-intermediary.jar:?] at net.minecraft.class_8847.method_54388(class_8847.java:8) ~[server-intermediary.jar:?] at net.minecraft.class_8854.method_54390(class_8854.java:107) ~[server-intermediary.jar:?] at net.minecraft.class_2170.method_54313(class_2170.java:379) ~[server-intermediary.jar:?] at net.minecraft.class_2170.method_9249(class_2170.java:309) ~[server-intermediary.jar:?] at net.minecraft.class_3244.method_58590(class_3244.java:1319) ~[server-intermediary.jar:?] at net.minecraft.class_3244.method_44356(class_3244.java:1307) ~[server-intermediary.jar:?] at net.minecraft.class_3738.run(class_3738.java:18) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_18859(class_1255.java:162) ~[server-intermediary.jar:?] at net.minecraft.class_4093.method_18859(class_4093.java:23) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_24306(MinecraftServer.java:864) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_18859(MinecraftServer.java:173) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_16075(class_1255.java:136) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_20415(MinecraftServer.java:846) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_16075(MinecraftServer.java:840) ~[server-intermediary.jar:?] at net.minecraft.class_1255.method_5383(class_1255.java:121) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_16208(MinecraftServer.java:814) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:702) ~[server-intermediary.jar:?] at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281) ~[server-intermediary.jar:?] at java.base/java.lang.Thread.run(Thread.java:1583) [?:?]

Versions (please complete the following information):

• Minecraft: 1.21
• Fabric Loader: 0.16.2
• Mod Version: 1.03

Additional context Mod list:

• antientitygrief 1.0.3
• anvilrestoration 2.2
• appleskin 3.0.2+mc1.21
• architectury 13.0.6
• audaki_cart_engine 3.1.1
• balm-fabric 21.0.4 -- kuma_api 21.0.2
• beautifiedchatserver 2.6
• betterbeaconplacement 3.4
• betterconduitplacement 3.3
• bettersnowballfights 1.21-1.0.2
• betterthanmending 2.1.0
• bluemap 5.3
• breedablekillerrabbit 3.5
• c2me 0.2.0+alpha.11.106+1.21 |-- c2me-base 0.2.0+alpha.11.106+1.21 |-- c2me-client-uncapvd 0.2.0+alpha.11.106+1.21 |-- c2me-fixes-chunkio-threading-issues 0.2.0+alpha.11.106+1.21 |-- c2me-fixes-general-threading-issues 0.2.0+alpha.11.106+1.21 |-- c2me-fixes-worldgen-threading-issues 0.2.0+alpha.11.106+1.21 |-- c2me-fixes-worldgen-vanilla-bugs 0.2.0+alpha.11.106+1.21 |-- c2me-notickvd 0.2.0+alpha.11.106+1.21 |-- c2me-opts-allocs 0.2.0+alpha.11.106+1.21 |-- c2me-opts-chunk-access 0.2.0+alpha.11.106+1.21 |-- c2me-opts-chunkio 0.2.0+alpha.11.106+1.21 |-- c2me-opts-math 0.2.0+alpha.11.106+1.21 |-- c2me-opts-scheduling 0.2.0+alpha.11.106+1.21 |-- c2me-opts-worldgen-general 0.2.0+alpha.11.106+1.21 |-- c2me-opts-worldgen-vanilla 0.2.0+alpha.11.106+1.21 |-- c2me-rewrites-chunk-serializer 0.2.0+alpha.11.106+1.21 |-- c2me-rewrites-chunkio 0.2.0+alpha.11.106+1.21 |-- c2me-server-utils 0.2.0+alpha.11.106+1.21 |-- c2me-threading-chunkio 0.2.0+alpha.11.106+1.21 |-- c2me-threading-lighting 0.2.0+alpha.11.106+1.21 |-- c2me-threading-worldgen 0.2.0+alpha.11.106+1.21 |-- com_electronwill_night-config_core 3.6.5 |-- com_electronwill_night-config_toml 3.6.5 |-- com_ibm_async_asyncutil 0.1.0 |-- net_objecthunter_exp4j 0.4.8 -- org_threadly_threadly 7.0
• capecommand 0.1.2-1.21
• carpet 1.4.147+v240613
• carpet-extra 1.4.147
• cloth-config 15.0.127 -- cloth-basic-math 0.6.1
• collective 7.79
• compacthelpcommand 2.7
• directionhud 1.7.1+1.21
• easyelytratakeoff 4.4
• expanded_armor_enchanting 1.0.8
• fabric-api 0.102.0+1.21 |-- fabric-api-base 0.4.42+6573ed8cd1 |-- fabric-api-lookup-api-v1 1.6.68+b5597344d1 |-- fabric-biome-api-v1 13.0.29+5bd9f1bcd1 |-- fabric-block-api-v1 1.0.22+0af3f5a7d1 |-- fabric-block-view-api-v2 1.0.10+6573ed8cd1 |-- fabric-blockrenderlayer-v1 1.1.52+0af3f5a7d1 |-- fabric-client-tags-api-v1 1.1.15+6573ed8cd1 |-- fabric-command-api-v1 1.2.49+f71b366fd1 |-- fabric-command-api-v2 2.2.28+6ced4dd9d1 |-- fabric-commands-v0 0.2.66+df3654b3d1 |-- fabric-content-registries-v0 8.0.16+b5597344d1 |-- fabric-convention-tags-v1 2.0.19+7f945d5bd1 |-- fabric-convention-tags-v2 2.5.0+c5e2b5c6d1 |-- fabric-crash-report-info-v1 0.2.29+0af3f5a7d1 |-- fabric-data-attachment-api-v1 1.1.27+6a6dfa19d1 |-- fabric-data-generation-api-v1 20.2.16+16c4ae25d1 |-- fabric-dimensions-v1 4.0.0+6fc22b99d1 |-- fabric-entity-events-v1 1.6.12+6fc22b99d1 |-- fabric-events-interaction-v0 0.7.12+ba9dae06d1 |-- fabric-game-rule-api-v1 1.0.53+6ced4dd9d1 |-- fabric-item-api-v1 11.0.0+afdfc921d1 |-- fabric-item-group-api-v1 4.1.4+78017270d1 |-- fabric-key-binding-api-v1 1.0.47+0af3f5a7d1 |-- fabric-keybindings-v0 0.2.45+df3654b3d1 |-- fabric-lifecycle-events-v1 2.3.12+6c1df360d1 |-- fabric-loot-api-v2 3.0.14+3f89f5a5d1 |-- fabric-loot-api-v3 1.0.2+3f89f5a5d1 |-- fabric-message-api-v1 6.0.13+6573ed8cd1 |-- fabric-model-loading-api-v1 2.0.0+fe474d6bd1 |-- fabric-networking-api-v1 4.2.2+60c3209bd1 |-- fabric-object-builder-api-v1 15.2.0+a551f7a4d1 |-- fabric-particles-v1 4.0.2+6573ed8cd1 |-- fabric-recipe-api-v1 5.0.12+65089712d1 |-- fabric-registry-sync-v0 5.1.2+60c3209bd1 |-- fabric-renderer-api-v1 3.4.0+c705a49cd1 |-- fabric-renderer-indigo 1.7.0+c705a49cd1 |-- fabric-renderer-registries-v1 3.2.68+df3654b3d1 |-- fabric-rendering-data-attachment-v1 0.3.48+73761d2ed1 |-- fabric-rendering-fluids-v1 3.1.6+b5597344d1 |-- fabric-rendering-v0 1.1.71+df3654b3d1 |-- fabric-rendering-v1 5.0.5+df16efd0d1 |-- fabric-resource-conditions-api-v1 4.3.0+8dc279b1d1 |-- fabric-resource-loader-v0 1.3.0+56599129d1 |-- fabric-screen-api-v1 2.0.24+b5597344d1 |-- fabric-screen-handler-api-v1 1.3.86+b5597344d1 |-- fabric-sound-api-v1 1.0.23+6573ed8cd1 |-- fabric-transfer-api-v1 5.1.16+3dccd343d1 -- fabric-transitive-access-wideners-v1 6.1.0+176f9036d1
• fabric-language-kotlin 1.11.0+kotlin.2.0.0 |-- org_jetbrains_kotlin_kotlin-reflect 2.0.0 |-- org_jetbrains_kotlin_kotlin-stdlib 2.0.0 |-- org_jetbrains_kotlin_kotlin-stdlib-jdk7 2.0.0 |-- org_jetbrains_kotlin_kotlin-stdlib-jdk8 2.0.0 |-- org_jetbrains_kotlinx_atomicfu-jvm 0.24.0 |-- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.8.1 |-- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.8.1 |-- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.6.0 |-- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.6.3 |-- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.6.3 -- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.6.3
• fabricloader 0.16.2 -- mixinextras 0.4.1
• fastback 0.19.0+1.21-fabric |-- com_googlecode_javaewah_javaewah 1.2.3 |-- fabric-permissions-api-v0 0.3.1 |-- net_i2p_crypto_eddsa 0.3.0 |-- org_apache_sshd_sshd-common 2.12.1 |-- org_apache_sshd_sshd-core 2.12.1 |-- org_eclipse_jgit_org_eclipse_jgit 6.8.0.202311291450-r |-- org_eclipse_jgit_org_eclipse_jgit_ssh_apache 6.8.0.202311291450-r -- server_translations_api 2.3.1+1.21-pre2
• ferritecore 7.0.0
• fixedanvilrepaircost 3.3
• fsit 2.4.1+1.21 |-- com_charleskorn_kaml_kaml-jvm 0.54.0 -- org_snakeyaml_snakeyaml-engine 2.6
• icepreventscropgrowth 3.4
• image2map 0.7.1+1.21 |-- map-canvas-api 0.4.1+1.21 -- sgui 1.6.0+1.21
• improved-signs 1.4.2 -- midnightlib 1.5.7
• inventorytotem 3.3
• jade 15.1.3+fabric
• java 21
• kleeslabs 21.0.2
• krypton 0.2.8 -- com_velocitypowered_velocity-native 3.3.0-SNAPSHOT
• lithium 0.12.7
• lithostitched 1.2.0
• luckperms 5.4.133 -- fabric-permissions-api-v0 0.3.1
• minecraft 1.21
• mods-command 1.1.7 |-- adventure-platform-fabric 5.14.0 | |-- net_kyori_adventure-api 4.17.0 | |-- net_kyori_adventure-key 4.17.0 | |-- net_kyori_adventure-platform-api 4.3.3 | |-- net_kyori_adventure-text-logger-slf4j 4.17.0 | |-- net_kyori_adventure-text-minimessage 4.17.0 | |-- net_kyori_adventure-text-serializer-ansi 4.17.0 | |-- net_kyori_adventure-text-serializer-gson 4.17.0 | |-- net_kyori_adventure-text-serializer-json 4.17.0 | |-- net_kyori_adventure-text-serializer-plain 4.17.0 | |-- net_kyori_ansi 1.0.3 | |-- net_kyori_examination-api 1.3.0 | |-- net_kyori_examination-string 1.3.0 | -- net_kyori_option 1.0.0 |-- cloud 2.0.0-beta.7 | |-- fabric-permissions-api-v0 0.3.1 | |-- io_leangen_geantyref_geantyref 1.3.15 | |-- org_incendo_cloud-brigadier 2.0.0-beta.8 | |-- org_incendo_cloud-core 2.0.0-rc.2 | |-- org_incendocloud-minecraft-modded-common-fabric-repack 2.0.0-beta.7 | -- org_incendo_cloud-services 2.0.0-rc.2 |-- org_incendo_cloud-minecraft-extras 2.0.0-beta.9 |-- org_spongepowered_configurate-core 4.2.0-SNAPSHOT |-- org_spongepowered_configurate-hocon 4.2.0-SNAPSHOT -- org_spongepowered_configurate-yaml 4.2.0-SNAPSHOT
• mooshroomtweaks 3.5
• moveboats 3.3
• mru 0.4.3+1.21 -- yet_another_config_lib_v3 3.5.0+1.21-fabric |-- com_twelvemonkeys_common_common-image 3.10.0 |-- com_twelvemonkeys_common_common-io 3.10.0 |-- com_twelvemonkeys_common_common-lang 3.10.0 |-- com_twelvemonkeys_imageio_imageio-core 3.10.0 |-- com_twelvemonkeys_imageio_imageio-metadata 3.10.0 |-- com_twelvemonkeys_imageio_imageio-webp 3.10.0 |-- org_quiltmc_parsers_gson 0.2.1 -- org_quiltmc_parsers_json 0.2.1
• netherportalfix 21.0.1
• nofeathertrample 1.3
• noisium 2.2.0+mc1.21
• notica 1.2.0+1.21 |-- kibu-access-lib 0.15.0+1.21 |-- kibu-hook-api 1.3.0 |-- kibu-hooks 0.50.0+1.21 |-- kibu-translation-api 0.17.0+1.21 | -- work_lclpnet_translations4j 2.7.0 |-- org_json_json 20230227 -- work_lclpnet_json-config4j 1.0.0
• notthatexpensive 1.0
• nullscape 1.2.7
• offlineplayersreworked 1.0.3
• oreharvester 1.4
• ouch 1.1.0+1.21 |-- placeholder-api 2.4.0+1.21 -- predicate-api 0.5.2+1.21
• polydecorations 0.4.2+1.21 |-- common-protection-api 1.0.0 |-- factorytools 0.3.1+1.21 |-- map-canvas-api 0.4.1+1.21 -- sgui 1.6.0+1.21
• polymer-bundled 0.9.7+1.21 |-- polymer-autohost 0.9.7+1.21 | -- io_netty_netty-codec-http 4.1.82 |-- polymer-blocks 0.9.7+1.21 |-- polymer-common 0.9.7+1.21 | -- packet_tweaker 0.5.5+1.21 |-- polymer-core 0.9.7+1.21 | |-- polymer-networking 0.9.7+1.21 | | -- polymer-common 0.9.7+1.21 | | -- packet_tweaker 0.5.5+1.21 | -- polymer-registry-sync-manipulator 0.9.7+1.21 |-- polymer-resource-pack 0.9.7+1.21 | -- polymer-common 0.9.7+1.21 | -- packet_tweaker 0.5.5+1.21 -- polymer-virtual-entity 0.9.7+1.21 -- polymer-common 0.9.7+1.21 -- packet_tweaker 0.5.5+1.21
• portable_crafting 3.0.1+1.21 -- folk_sisby_kaleido-config 0.3.1+1.3.2
• randombonemealflowers 4.6
• randomsheepcolours 3.4
• scaffoldingdropsnearby 3.3
• setworldspawnpoint 3.3
• shulkerbox 1.21.1-2.0.5
• snowundertrees 2.4.0+1.21 -- yet_another_config_lib_v3 3.5.0+1.21-fabric |-- com_twelvemonkeys_common_common-image 3.10.0 |-- com_twelvemonkeys_common_common-io 3.10.0 |-- com_twelvemonkeys_common_common-lang 3.10.0 |-- com_twelvemonkeys_imageio_imageio-core 3.10.0 |-- com_twelvemonkeys_imageio_imageio-metadata 3.10.0 |-- com_twelvemonkeys_imageio_imageio-webp 3.10.0 |-- org_quiltmc_parsers_gson 0.2.1 -- org_quiltmc_parsers_json 0.2.1
• spark 1.10.73 -- fabric-permissions-api-v0 0.3.1
• stackrefill 4.5
• stretchy-leash 2.1.0+1.21
• toms_mobs 2.0.0+1.21 -- bil 1.1.9+1.21
• treeharvester 8.9
• universal_perms 1.0.5
• villagernames 7.4
• villagertrades 1.21-1.0.2
• welcomemessage 2.5
• worldedit 7.3.6+6892-3d660b8
• wsnds 0.1.1

[TheMisterFish]

Comparing the error log with the code this has to do with the chatSession being null. The auto disconnect option doesn't affect this, that is more of a kind of debug config setting.

I'll try resolving this asap, thanks for finding.

[TheMisterFish]

@Tellsanguis ~would you like to test the 1.0.4 jar before I release in case there are more bugs? On my own server I didn't get this one.~ I've updated it in release 1.0.4.

[Tellsanguis]

It works! The player appears and I can decide on his actions.

I'm doing some tests, and it doesn't look like the fake player can spawn mobs (or at least raids, after testing in my raid farm). Maybe because the real player is still connected? I'll do some more tests (including some with the main player offline) and get back to you

[TheMisterFish]

Thank you for testing! Much appreciated.

[TheMisterFish]

I think you are correct regarding starting a raid. It should work using the eat action but doesn't because there's a statement that checks if the player can eat. In that check a player can only eat if he's hungry. I'll create a enhancement ticket to fix this.

https://github.com/TheMisterFish/Fabric_OfflinePlayersReworked/issues/18

[TheMisterFish]

@Tellsanguis 1.0.5 is now released. I've added a check to see if the ominous effect is active, if it is active the offlinePlayer will not drink a new bottle. But this does mean that when the raid starting, the offlinePlayer is able to drink a new bottle. I don't know about the exact timing but you could try something like /offline eat:1.5m to only trigger the effect every one and a half minute. Let me know if this is a good solution; otherwise feel free to create a Enhancement ticket 💪

[Tellsanguis]

Thanks for your work! I'll test it all tomorrow in my spare time 💪

[Tellsanguis]

Hey! Sorry for my late return! After several tests, everything works perfectly! The optimal command for the raid farm model I'm using, from TurtleCraft in 1.21, seems to be /offline attack:15 eat: (at 14 I have no mobs spawn). The potions are well drunk, and at the right interval (I had a workaround before the updates where I made my player hungry to drink the potions). For all farms where it only requires the player's presence, it's perfect!

In short, your mod is absolutely brilliant and allows me to give other players on my server access to a command that lets them farm without being in front of their computer, and without giving them huge permissions like with the Carpet mod! Thank you so much!

[TheMisterFish]

Thank you very much for the kind words! Glad the mod works well 😁