search

TheMulhima / Lumafly

A cross platform mod manager for Hollow Knight written in Avalonia.
https://themulhima.github.io/Lumafly/
GNU General Public License v3.0
132 stars 18 forks source link

Modpacks sometimes fail to load, possibly when mods in pack are already downloaded but disabled #124

Open Arwangha opened 1 month ago

Arwangha commented 1 month ago

Lumafly Version

v3.3.0.0

Hollow Knight Version

v1.5.78.11833

Steps to Reproduce

Load any pack that contains at least one mod that is already installed by disabled. Although I'm not 100% sure that this is the cause of the issue, that seemed consistent. This happens on mac. This issue isn't specific to this version of Lumafly, and was already happening before.

Expected Behaviour

The modpack is loaded.

Actual Behaviour

An error occurs, with a message attached below, and the installer reverts to the previous mods.

Errors and Logs

An error occured when activating pack. Lumafly will revert to old mods

Lumafly Version: 3.3.0.0

Lumafly.Util.ReadableError: because it doesn't exist where it is supposed to. Please try to reinstall the mod at Lumafly.Services.Installer._Toggle(ModItem mod, Boolean enabled, ExistsModState state) at Lumafly.Services.Installer.Toggle(ModItem mod) at Lumafly.Services.Installer._Install(ModItem mod, Action1 setProgress, Boolean enable, Boolean clearDlls) at Lumafly.Services.Installer._Install(ModItem mod, Action1 setProgress, Boolean enable, Boolean clearDlls) at Lumafly.Services.Installer.Install(ModItem mod, Action`1 setProgress, Boolean enable, Boolean clearDlls) at Lumafly.Services.PackManager.LoadPackExclusive(Pack pack)