TheMulhima / Lumafly

A cross platform mod manager for Hollow Knight written in Avalonia.
https://themulhima.github.io/Lumafly/
GNU General Public License v3.0
132 stars 18 forks source link

Remembering version when moving mods manually #69

Closed Acu1000 closed 1 year ago

Acu1000 commented 1 year ago

Explanation of the new feature

Currently when you remove a mod manually, put it somewhere else (for example for backup or testing purposes) and use scarab, when you later put the mod back into the game's mod folder, Scarab thinks the mod version is not from modlinks and shows the update button near it, despite the mod being up to date. I believe this is caused by the fact that versions of the mods are stored in the InstalledMods.json file, which is in a completely different location.

My idea on how to fix this is to have Scarab add a "version" file to the mod's directory that contains just the current version of the mod, whenever a mod from modlinks is installed/updated. This way the version wouldn't get forgotten whenever user moves the mod files somewhere else and Scarab could recognize up-to-date modlinks mods without depending on the .json file.

The version in the .json would still take priority, but if the mod is not present in the .json file, it should automatically put the version there from the created file. temp

TheMulhima commented 1 year ago

Shouldn't be a problem anymore with modpacks.