TheMulhima / Lumafly

A cross platform mod manager for Hollow Knight written in Avalonia.
https://themulhima.github.io/Lumafly/
GNU General Public License v3.0
132 stars 18 forks source link

Github mirror #93

Closed ghost closed 11 months ago

ghost commented 12 months ago

Explanation of the new feature

Use mirror sites instead of downloading content directly from github.

This can greatly improve the user experience for Chinese users

I want to make sure if this feature will be accepted. If I could, I would implement it myself

TheMulhima commented 12 months ago

Sure that would be amazing.

Although, with the current version, it already is possible. It was implemented in this commit 7b23edd. The idea was that you could ask the user to edit the base link field and point it to the mirror site which downloads custom versions of ModLinks and ApiLinks that probably would have different download links for mods. The edit could happen by asking user to edit the settings file, or running the URI command via the website or command line. However, it hasn't been used yet so If you'd like to implement a different system that will be used I'd happily accept it