search

TheMysterys / Server-Pack-Unlocker

1.17 -> 1.20.2
https://modrinth.com/mod/server-pack-unlocker
The Unlicense
7 stars 4 forks source link

do not reload the resources, if resource pack order didn't change #16

Closed MrKinau closed 4 months ago

MrKinau commented 10 months ago

The issue I intend to fix with this PR is, that the resource pack loading screen will show up upon closing the resource pack selection screen, even if no change was made in the screen. This happens, because Minecraft detects a new resource pack ("server") and triggers a reload. Not sure if this is the "right" way to fix this, but it works (on my machine). Additionally I fixed a crash during startup, which happened to me in the dev environment, because the config folder was not created while Server-Pack-Unlocker loads, not sure if this could happen in a real environment.

TheMysterys commented 10 months ago

Does this change let the client reload if packs have been moved but not the "server" pack?

Will do some tests myself but wanted to ask before hand incase you already knew

MrKinau commented 10 months ago

It does reload, if the order of the enabled resource packs changes, even if the server pack is not moved.

TheMysterys commented 4 months ago

Due to changing how the mod works now, this can't be implemented.