search

TheMysterys / Server-Pack-Unlocker

1.17 -> 1.20.2
https://modrinth.com/mod/server-pack-unlocker
The Unlicense
7 stars 4 forks source link

update to 1.20.4 #19

Closed AugSakura closed 5 months ago

AugSakura commented 8 months ago

My English is not good, so I'm using GPT to help me translate what I'm about to say. In version 1.20.4, the official team removed the ServerResourcePackProvider class. Therefore, I used the newly added ServerResourcePackLoader class in 1.20.4 to achieve the same functionality. I'm not sure if my approach is the optimal solution, but it is currently working reliably in my server group.

yannicksuc commented 7 months ago

Didn't need to update the gradle.properties file ? Not working for me personally with this one : 

org.gradle.jvmargs=-Xmx1G
# Fabric Properties
# check these on https://modmuss50.me/fabric.html
minecraft_version=1.20.4
yarn_mappings=1.20.4+build.3
loader_version=0.15.7
# Mod Properties
mod_version=1.7
maven_group=com.themysterys
archives_base_name=spu
# Dependencies
fabric_version=0.96.11+1.20.4

And have an error with packinfo.path()

Server-Pack-Unlocker\src\main\java\com\themysterys\spu\mixin\ServerResourcePackLoaderMixin.java:42: error: cannot access Record Path path = packInfo.path(); ^ class file for java.lang.Record not found

TheMysterys commented 5 months ago

Already updated on my end now