search

TheNAF / naflm

NAFLM - NAF League Manager
Other
35 stars 34 forks source link

Hide Aging dropdowns on Match Report #140

Open mfranchetti opened 8 years ago

mfranchetti commented 8 years ago

In order to streamline the Match Report screen, I'd like to propose hide the Aging Dropdowns. I could be wrong, but I don't believe they're in common use across most leagues these days. Best solution would be to make it an option at the League level (Division?) and show/hide them on that basis. Easy enough to make it an entry in the settings.php file, but might be better added as a database field and incorporated into League Preferences.

Shteve0 commented 8 years ago

Good shout On 30/06/2016 8:55 PM, "Michael" notifications@github.com wrote:

In order to streamline the Match Report screen, I'd like to propose hide the Aging Dropdowns. I could be wrong, but I don't believe they're in common use across most leagues these days. Best solution would be to make it an option at the League level (Division?) and show/hide them on that basis. Easy enough to make it an entry in the settings.php file, but might be better added as a database field and incorporated into League Preferences.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TheNAF/naflm/issues/140, or mute the thread https://github.com/notifications/unsubscribe/AMve2-CxkbAHiMJAii1YNza0hPfW-gCfks5qQ4SCgaJpZM4JB8OR .

darkporpoise commented 8 years ago

Would it be easy to query the NAF database to see if these have ever been recorded against a match? If not, I would suggest just hiding or even removing them.

rythos42 commented 8 years ago

I'll take a look at the NAF database sometime today to answer your question, it's a good one.

Adding as a database field is (assuming #138 happens) a best practice from here on.

(also, I like the "question" tag, but I don't think we need "Proposal:" in the title as well)

rythos42 commented 8 years ago

The aging fields are stored in a table that has 1 row per player, per match. Out of 37061 entries in this table, 7 of them have an aging field set to something other than NONE (~0.02%). 5 of these rows are set by the same coach, the remaining 2 by a different coach. So out of 483 coaches in the system, 2 of them have used the aging feature (~4%).

I'd say we could easily hide this feature behind a league setting flag and be happy about it.

darkporpoise commented 8 years ago

Just had a thought: How do we currently record multiple injuries for players with Decay? Could that be the 7 rows currently recorded as aging?

Equally, how would we record an injury if we didn't want the MNG? i.e. injury in last match of league season.

rythos42 commented 8 years ago

Decay is likely through the Aging columns - there is only the one Injury column. If we set the Show/Hide to be a League flag, leagues could determine for themselves whether to show it or not.

My league has been recording Injuries as-is, and then then Commissioner removes the MNG for every team at the end of the season.

Alternatively, we could have the Show/Hide flag be on the Match report (and default to "Hide") so players could have the option per-match.

darkporpoise commented 8 years ago

Either way I would suggest renaming the input away from "Aging". I feel like LRB6 should be properly supported out of the box so Decay injuries should always be recordable by the person filling out the match report, regardless of League settings.

A per-match setting would work but would a per-player flag be better for those with Decay? I guess it depends whether we are also trying to make it work for aging...

mfranchetti commented 8 years ago

This is a fairly low impact problem as there are only two players affected (Khemri: Tomb Guardians; Nurgle: Rotters) unless I'm missing any? In addition, the only time the second injury needs to be recorded is when both injuries are SIs, so only 1/36 casualties. In any other case the SI will be overruled by Death or make the BH/MNG irrelevant. It may by simpler to alter the Injury dropdown for those specific players to include the possible combinations: image It increases the options from 8 to 23 but I suspect it might be easier to manage on the back end and would affect a minority of players.

darkporpoise commented 8 years ago

That works well I think. Then you can go back to Plan A on the aging and hide the fields with a League level toggle.

mfranchetti commented 8 years ago

Ok, I'll move the expansion of Injuries to a new issue then.