search

TheNAF / naflm

NAFLM - NAF League Manager
Other
35 stars 34 forks source link

Match Report: Expand Injury Dropdown to allow for Decay #142

Open mfranchetti opened 8 years ago

mfranchetti commented 8 years ago

Players with Decay can be affected by two Injury results from a single match. At the moment, the Match Report (and OBBLM) does not support the recording and handling of this. Currently, this is only an issue for two players positions (Khemri: Tomb Guardians; Nurgle: Rotters) and only when both injuries are SIs, so only 1/36 casualties. In any other case the SI will be overruled by Death or make the BH/MNG irrelevant.

Proposed solution is to alter the Injury dropdown for those specific players to include the possible combinations: image It increases the options from 8 to 23 but I suspect it might be easier to manage on the back end and would affect a minority of players.

Shteve0 commented 8 years ago

I think better to do it where the player has decay, rather than for those specific players? May be edge case but as it's a result of the skill and not tied to the positional it would be better supported in the event of roster changes or additions down the line (or where skills are abnormally allocated by a commissioner) On 7/07/2016 1:07 AM, "Michael" notifications@github.com wrote:

Players with Decay can be affected by two Injury results from a single match. At the moment, the Match Report (and OBBLM) does not support the recording and handling of this. Currently, this is only an issue for two players positions (Khemri: Tomb Guardians; Nurgle: Rotters) and only when both injuries are SIs, so only 1/36 casualties. In any other case the SI will be overruled by Death or make the BH/MNG irrelevant.

Proposed solution is to alter the Injury dropdown for those specific players to include the possible combinations: image It increases the options from 8 to 23 but I suspect it might be easier to manage on the back end and would affect a minority of players.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/TheNAF/naflm/issues/142, or mute the thread https://github.com/notifications/unsubscribe/AMve29co_J-iTBPrJ0OSKxY-P7Fc0wNsks5qS6h1gaJpZM4JGD0a .

mfranchetti commented 8 years ago

Yes, agreed and that was my original intention. I was just flagging the players to highlight that it is a low impact issue.

Shteve0 commented 8 years ago

Gotcha :) On 7/07/2016 10:51 PM, "Michael" notifications@github.com wrote:

Yes, agreed and that was my original intention. I was just flagging the players to highlight that it is a low impact issue.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/TheNAF/naflm/issues/142#issuecomment-231045876, or mute the thread https://github.com/notifications/unsubscribe/AMve294BZWmXlz8RAfDwsR8TTPySaUGyks5qTNoogaJpZM4JGD0a .