search

TheNAF / naflm

NAFLM - NAF League Manager
Other
35 stars 34 forks source link

LeaguePref requires two tournaments #2

Open Shteve0 opened 9 years ago

Shteve0 commented 9 years ago

LewaguePref forces check on two different tournaments before updates can be processed. No need for this that I can see - prohibits ability to changes title, welcome, site etc without multiple tournaments

Shteve0 commented 8 years ago

Why the reference here Craig? Any thoughts on a fix?

Shteve0 commented 8 years ago

Thinking just the option for a NULL would be good

darkporpoise commented 8 years ago

Is this used to determine which events/standings boxes are seen on the home page for logged in users? I have seen reference to get_second/prime in the settings_N.php files. Would NULL break those or just stop them appearing?

Shteve0 commented 8 years ago

Just stop them appearing On 24/11/2015 1:31 am, "Tom" notifications@github.com wrote:

Is this used to determine which events/standings boxes are seen on the home page for logged in users? I have seen reference to get_second/prime in the settings_N.php files. Would NULL break those or just stop them appearing?

— Reply to this email directly or view it on GitHub https://github.com/TheNAF/naflm/issues/2#issuecomment-158920801.

Shteve0 commented 8 years ago

I've got around this by hiding the ability to change the second league ID. I've also had all of the other boxes derive the division or league ID from the tournament prime. It means that when setting up a new line in the leaguepref table I'm needing to set the second tid to 0 to prevent it erroring; not the most elegant of solutions, to be honest, but functioning.

rythos42 commented 8 years ago

ha! I didn't get a notification of your question here Steve...it linked because I wrote "# 2" in the comments, and it referenced Issue 2. >.<

rythos42 commented 8 years ago

@Shteve0 Are you happy with how this is working?

Shteve0 commented 8 years ago

Not 100%. It's getting by, just about, but if you submit two ids the same to the table then the prefs will fall over with a comedy warning.

Ultimately I'd like it to handle much more flexibility, but yeah, it's still a little patchy. On 11/02/2016 10:28 am, "Craig Fleming" notifications@github.com wrote:

@Shteve0 https://github.com/Shteve0 Are you happy with how this is working?

— Reply to this email directly or view it on GitHub https://github.com/TheNAF/naflm/issues/2#issuecomment-182589149.