search

TheNAF / naflm

NAFLM - NAF League Manager
Other
35 stars 34 forks source link

On success or fail of install - install.php is renamed #279

Closed thefloppy1 closed 4 years ago

thefloppy1 commented 4 years ago

Regardless of success or fail the installer is renamed.

need to check for success before the installer is renamed.

snotlingorc commented 4 years ago

Looking that the install.php, the rename is inside "if ($setupOK) {" If the setup fails, the rename should not happen. I am wondering if "setup_database()" has an invalid return.

What failure is happening where the installer is renamed?

thefloppy1 commented 4 years ago

when I test I always do the following on a new install.

I start at the beginning setting up a new DB. I always test to make sure when you don't grant permissions the right error comes up, then grant permissions to the db run installer again, but the file was not found, it had been renamed.

snotlingorc commented 4 years ago

I see. on the first time around, you do see the message "Renaming the install.php file from your OBBLM folder", correct? If that is the case, then sadly, the setup_database function is not returning the correct result.

thefloppy1 commented 4 years ago

let me cycle up a new install and I will tell you.

thefloppy1 commented 4 years ago

I have ran the installer several times in a row, it is not the create procedure privilege that is missing it is create. When the sql functions/procedures run it returns that the setup_database() that it is setup and correct. The file is renamed.

Creating core tables... FAILED — coaches FAILED — teams FAILED — players FAILED — memberships FAILED — players_skills FAILED — races FAILED — leagues FAILED — divisions FAILED — tours FAILED — matches FAILED — match_data FAILED — texts FAILED — game_data_players FAILED — game_data_stars FAILED — game_data_skills FAILED — mv_players FAILED — mv_teams FAILED — mv_coaches FAILED — mv_races FAILED — mv_es_players FAILED — mv_es_teams FAILED — mv_es_coaches FAILED — mv_es_races FAILED — match_data_es Creating module tables... FAILED — wanted FAILED — hof FAILED — prizes FAILED — log FAILED — conferences FAILED — conference_teams FAILED — league_prefs FAILED — cemetery FAILED — famousteams Other tasks... FAILED — Error whilst synchronizing game data with database FAILED — could not apply one more more table indexes OK — created MySQL functions/procedures FAILED — root user was not created.

Finished

Effectively returning a False Positive.

snotlingorc commented 4 years ago

Looks like you did find something here. Looking at lib/mysql.php (lines 974 to 1018). the setup_database function ends with return true;. It has no error checking.

thefloppy1 commented 4 years ago

Tested and this can be closed.

cheers

snotlingorc commented 4 years ago

Just wondering, do you want to leave this open until the pull request is merged?

thefloppy1 commented 4 years ago

That might be an idea, I may have jumped the gun a bit.

On Sun, 19 Jul 2020, 12:30 Snotling, notifications@github.com wrote:

Just wondering, do you want to leave this open until the pull request is merged?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/TheNAF/naflm/issues/279#issuecomment-660574905, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD25NBWVK3VGAFKPTD7LOBLR4JLC5ANCNFSM4OXUHYVA .