TheNetsky / Microsoft-Rewards-Script

Automated Microsoft Rewards script, using TypeScript, Cheerio and Playwright.
133 stars 33 forks source link

Increasing timeout on login and go-home #103

Closed serzak51 closed 2 months ago

serzak51 commented 2 months ago

The script will wait 60 seconds for the page to load instand of 30 seconds. For really slow connection a 2 minutes timeout on the go-home might be necessary (for the login 60 seconds seems to never produce any error) Also does anywone know how i remove the first commit? When testing i modified it directly on the compiled code, tried uploading, but it wasn't the same format, and now deleting the file doesn't work, and i can't find a button to revert the commit

serzak51 commented 2 months ago

Nevermind i found it, i just didn't commit the delete action

TheNetsky commented 2 months ago

I've already tinkered with some timeout in a new upcoming version, however not being able to load a page in 30 seconds (default timeout) is quite something. Searches must be taking forever. So I don't really think increasing the timeout is really a solution to something like that. I think it would be better to get a VPS or alike that has some better connection.

Oussema-Hakim commented 2 months ago

increasing timeout actually helped me, obviously when i search the page doesn't take that long but for some reason when i use multiple clusters (i m using 4 ) the 30s timeout is guaranteed to trigger at least once , not sure why but i tried using one cluster and it didn't happen. probably an unstable internet problem thingy , my bandwidth is alright but probably not consistent , in my case i added this line in Browser.ts instead of adding timeout option, and i added loadTimeout field to config file context.setDefaultTimeout(this.bot.config.searchSettings.loadTimeout)

serzak51 commented 2 months ago

I don't even think it's actually user related. Often yeah 30 seconds is overkill, but sometimes for some reason it takes ages to load pictures, not sure why. And on one of my connection it actually was triggered every time. It was wireless fiber, so maybe instand of loading the images in parrellel, microsoft decided to load them sequentially, meaning that high ping increase the load time? Just a theory, i'm not even sure you can do that