search

TheNetsky / community-extensions

A repo with community made Paperback sources.
https://thenetsky.github.io/community-extensions/0.8
GNU General Public License v3.0
13 stars 31 forks source link

Fix blank pages at the end of chapters #16

Closed hyoretsu closed 1 year ago

hyoretsu commented 1 year ago

fixes #10. The previous condition 'page !== null' was never true because it came as undefined from the map()

It was intended to filter only entries with mangaPage, but turned out it wasn't.

TheNetsky commented 1 year ago

If you tested it and it works, inc version

hyoretsu commented 1 year ago

Sorry for the question, but how do I test it on a physical device after running npm run serve? I'm 99.9% sure it works, since I tested it on a JS console, but it's still better to actually test it.

TheNetsky commented 1 year ago

You run that, then you add a repo on your Paperback that is your PC's local ip so 192.168.xx.xx:8080

hyoretsu commented 1 year ago

Yup, I took a bit of a workaround to run it but confirmed working.