search

TheNetsky / extensions-generic-0.8

Common CMS Extensions for Paperback 0.8
https://thenetsky.github.io/extensions-generic-0.8/
18 stars 26 forks source link

Buddycomplex Chapter Regex Hell #3

Closed niclimcy closed 1 year ago

niclimcy commented 1 year ago

Imagine having weird chapters like afterword and chapter 0

TheNetsky commented 1 year ago

Tested?

niclimcy commented 1 year ago

Tested?

Works fine but I am not sure if it is worth the extra complexity to first search for ‘chapter-‘ and falling back to original method if it fails

niclimcy commented 1 year ago

IMG_7661 Hmm sorting index seems inconsistent again, i’ll need to look at this later

niclimcy commented 1 year ago

I cannot replicate this anymore, seems like source inconsistent labelling/relabelling is at fault and not my changes

TheNetsky commented 1 year ago

I cannot replicate this anymore, seems like source inconsistent labelling/relabelling is at fault and not my changes

So what's the plan with this PR? Did it fix it or does it not matter since it's borked regardless?

niclimcy commented 1 year ago

I cannot replicate this anymore, seems like source inconsistent labelling/relabelling is at fault and not my changes

So what's the plan with this PR? Did it fix it or does it not matter since it's borked regardless?

It makes chapter labelling more consistent on certain mangas where they include season numbers in the url.

TheNetsky commented 1 year ago

I cannot replicate this anymore, seems like source inconsistent labelling/relabelling is at fault and not my changes

So what's the plan with this PR? Did it fix it or does it not matter since it's borked regardless?

It makes chapter labelling more consistent on certain mangas where they include season numbers in the url.

Nice, but are you sure that didn't go at the cost of other manga?

niclimcy commented 1 year ago

It falls back to the old regex when it doesn’t find “chapter”