TheNetsky / extensions-generic-0.8

Common CMS Extensions for Paperback 0.8
https://thenetsky.github.io/extensions-generic-0.8/
20 stars 27 forks source link

New Source: NightScans #47

Closed seitenca closed 1 year ago

seitenca commented 1 year ago

the sections (new titles, top all time, top monthly, top weekly) only have 5 entries, what is better disable it or not?

TheNetsky commented 1 year ago

Remove trailing slash from domain, also up to you.

TheNetsky commented 1 year ago

I hope you're also properly testing your sources for all functions correct? A generic doesn't mean it works for all, even if it is supposed to.

seitenca commented 1 year ago

I hope you're also properly testing your sources for all functions correct? A generic doesn't mean it works for all, even if it is supposed to.

How do you test it? I try to search a lot of mangas, search by tags / word, test home section, check mangadetails. If I'm missing something or there is a better way for it, say me please since I'm new to this, and I want to learn

TheNetsky commented 1 year ago

I hope you're also properly testing your sources for all functions correct? A generic doesn't mean it works for all, even if it is supposed to.

How do you test it? I try to search a lot of mangas, search by tags / word, test home section, check mangadetails. If I'm missing something or there is a better way for it, say me please since I'm new to this, and I want to learn

Nah, that's what I meant, all those things on multiple items to be sure.

seitenca commented 1 year ago

Ok last thing before merging, this source have /manga & /series working, but /series is promoted. Which is better?

TheNetsky commented 1 year ago

Ok last thing before merging, this source have /manga & /series working, but /series is promoted. Which is better?

The one that is most common.

seitenca commented 1 year ago

Ok last thing before merging, this source have /manga & /series working, but /series is promoted. Which is better?

The one that is most common.

The default you mean? if so, you can merge whenever you want