TheNetsky / extensions-generic-0.8

Common CMS Extensions for Paperback 0.8
https://thenetsky.github.io/extensions-generic-0.8/
18 stars 25 forks source link

New Source: EnryuManga #54

Closed EmZedH closed 10 months ago

TheNetsky commented 10 months ago

Tested all features?

EmZedH commented 10 months ago

yes, just need to add author and artist selectors

EmZedH commented 10 months ago

The author and artist selectors for this site are not included in the parseMangaDetails()

Can i make changes to this function in the MangaStreamParser class to include this sites selectors, or, should i make my own implementation of getMangaDetails() within EnryuManga.ts

TheNetsky commented 10 months ago

Try if const author = $(span:contains(${source.manga_selector_author}), .fmed b:contains(${source.manga_selector_author})+span, .imptdt:contains(${source.manga_selector_author}) i, td:contains(${source.manga_selector_author})).contents().remove().last().text().trim() // Language dependant

const artist = $(span:contains(${source.manga_selector_artist}), .fmed b:contains(${source.manga_selector_artist})+span, .imptdt:contains(${source.manga_selector_artist}) i, td:contains(${source.manga_selector_artist})).contents().remove().last().text().trim() // Language dependant

Works within the parser, without breaking the other sources.

TheNetsky commented 10 months ago

If it does, you can change to that within MangaStreamParser.

EmZedH commented 10 months ago

nope doesnt seems to work

TheNetsky commented 10 months ago

Here you go

TheNetsky commented 10 months ago

Also your covers aren't loading for Project Updates and Last Updates.

EmZedH commented 10 months ago

Here you go

Tried it in my code...wasn't working Is it working for u?

TheNetsky commented 10 months ago

Here you go

Tried it in my code...wasn't working Is it working for u?

New one I posted works, see commit, also make sure to NOT open a manga that you've already opened because it's cached.

EmZedH commented 10 months ago

Also your covers aren't loading for Project Updates and Last Updates.

Seems to be a fault on the website due to its slow loading

Tried constant refreshing...it eventually loads the images

TheNetsky commented 10 months ago

Also your covers aren't loading for Project Updates and Last Updates.

Seems to be a fault on the website due to its slow loading

Tried constant refreshing...it eventually loads the images

You sure? View more loads them fast, the homepage does not.

EmZedH commented 10 months ago

Also your covers aren't loading for Project Updates and Last Updates.

Seems to be a fault on the website due to its slow loading

Tried constant refreshing...it eventually loads the images

You sure? View more loads them fast, the homepage does not.

Yes sometimes deleting and reinstalling extension or refreshing only worked...there was no issue with image selectors as I checked

TheNetsky commented 10 months ago

Also your covers aren't loading for Project Updates and Last Updates.

Seems to be a fault on the website due to its slow loading

Tried constant refreshing...it eventually loads the images

You sure? View more loads them fast, the homepage does not.

Yes sometimes deleting and reinstalling extension or refreshing only worked...there was no issue with image selectors as I checked

Can you share an image?

EmZedH commented 10 months ago
photo1 photo2
TheNetsky commented 10 months ago

Good enough then.