TheNetworg / oauth2-azure

Azure AD provider for the OAuth 2.0 Client.
https://packagist.org/packages/thenetworg/oauth2-azure
MIT License
230 stars 108 forks source link

paging_scenarios #136

Closed bigdevwhale closed 3 years ago

bigdevwhale commented 3 years ago

Adding ability for paging collections of resources that derive from directoryObject like collections of users or groups.

For paging scenarios $skipToken parameter needs to be utilized instead along with $top parameter.

Docs: https://docs.microsoft.com/en-us/graph/paging

hajekj commented 3 years ago

Thanks for the pull request! I think this has to be done a little bit different, since merging this would introduce a breaking change (eg. get would now return different kind of an object in some cases).

I agree that this is something which would be best supported so here are the options:

What are your thoughts?

/cc: @Marat555

bigdevwhale commented 3 years ago

@hajekj I like the second option. made the appropriate commits

hajekj commented 3 years ago

Awesome! I have merged this PR, thanks for the contribution @Marat555! I will release this as v2.0.2 later today, since there is no breaking change and simply extends the existing functionality.